Repository navigation
package/xxhash: fix libxxhash.pc prefix to /usr - #1209
Open
RetroBoyCN wants to merge 1 commit into
Open
RetroBoyCN wants to merge 1 commit into
RetroBoyCN wants to merge 1 commit into
Conversation
The libxxhash.pc file is generated during the build step, not during install. At that point PREFIX was not passed, so it defaulted to /usr/local, resulting in an incorrect pkg-config file pointing to /usr/local instead of /usr. Pass PREFIX=/usr in XXHASH_BUILD_CMDS so that the .pc file is generated with the correct prefix from the start.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Getting the following error when compiling shadps4 0.20.0:
CMake Error in CMakeLists.txt:
Imported target "PkgConfig::XXHASH" includes non-existent path
"/x86_64/host/x86_64-buildroot-linux-gnu/sysroot/usr/local/include"
in its INTERFACE_INCLUDE_DIRECTORIES. Possible reasons include:
provide.
The libxxhash.pc file is generated during the build step, not during install. At that point PREFIX was not passed, so it defaulted to /usr/local, resulting in an incorrect pkg-config file pointing to /usr/local instead of /usr.
Pass PREFIX=/usr in XXHASH_BUILD_CMDS so that the .pc file is generated with the correct prefix from the start.