Repository navigation
Add twitter:site and twitter:creator to every X card - #206
Merged
Merged
Conversation
basement.studio's card, which X renders, sets both to @basementstudio. X's card markup requires twitter:site, and without it the editor link fell back to the compact text-only card.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
 [Low impact] The PR appears safe to merge.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Matches basement.studio (website-2k25), whose GIF card renders on X: it sets `twitter:site` and `twitter:creator` to `@basementstudio`. Shader Lab set neither, and X's card markup requires `twitter:site` for `summary_large_image`. The editor link was showing X's compact text-only fallback.
Adds both to the root layout, the editor page, and the community scene, profile and effect pages (each of those replaces the layout's `twitter` object).
🤖 Generated with Claude Code