Skip to content

Add Cells edge scatter and editable editorial studies - #163

Merged
git-chad merged 29 commits into
git-chad/shader-lab-v3-planfrom
git-chad/v3-cell-editorial-studies
Oct 1, 2026
Merged

git-chad merged 29 commits into
git-chad/shader-lab-v3-planfrom
git-chad/v3-cell-editorial-studies

Conversation

@git-chad

Copy link
Copy Markdown
Collaborator

Photographic Cells can now break coherent edges into small seeded fragments with one Edge Scatter control in Regions and Paint. It shifts selection lookups within a bounded band while preserving cell positions, photographic detail, and stored paint. Zero remains the default and reproduces the earlier edge; Individual Cells ignores it. Editor and runtime use the same implementation, with no extra source samples, pass, target, or readback.

Two editable studies combine the existing Gradient/Halftone layers with Cells, independent text, and original SVG linework. The actual references 05 (color cells) and 11 (bridge) were reopened and compared with real renders. The studies and PNG previews are in public/examples/v3/; reference images are not bundled. Fine dots already work below Cells inside an isolated group, so no extra halftone controls were added.

Stacks onto #162 (git-chad/v3-threshold-colors). Part of integration #150; no V3 merges to main until the plan is complete. User authorized continuing with this slice while away; visual acceptance remains pending.

Validation:

  • bun run check passes with the same three pre-existing lint warnings.
  • Full bun run test:composition passes: 216 Cells editor/runtime GPU cases, including 38 new Scatter cases; real hydration/history/save-reopen, runtime frame/PNG parity, and legacy defaults.
  • bun tests/composition/editorial-studies-ui.mjs passes actual controls, undo/redo, layout visibility, both bundled studies, .lab download/reimport. The test waits for import completion, not just an already present layer row.
  • Bounded decoded-video off/on comparison at 640×480 and 1080p. Software-adapter 1080p medians: Random 60/60.8ms, Light 91.7/90.4ms, Paint 56.6/56.6ms. No native FPS or thermal claim.

Limits: high Scatter can fragment narrow painted details; tone-driven regions still change with video luminance. Native sustained performance and encoded export remain roadmap 7.2. The examples demonstrate the visual ingredients, not final V3 acceptance. The current viewport-sized canvas changes framing with window size, and the 48px text minimum limits small annotations; both findings are recorded in the roadmap and recipe.

@vercel

vercel Bot commented Sep 17, 2026 •

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
shader-lab Ready Ready Preview Oct 1, 2026 7:06am UTC

@greptile-apps

greptile-apps Bot commented Sep 17, 2026

Copy link
Copy Markdown

RetriggerConfidence Score: 4/5

The production changes appear safe to merge; only the new optional browser QA script needs non-blocking portability and artifact-directory fixes.

Summary

This PR adds seeded Edge Scatter to Photographic Cells in both editor and React runtime renderers, exposes and persists the control, and adds two editable V3 editorial studies with bundled assets and expanded GPU/UI/performance coverage.

  • Scatter changes selection lookups while preserving cell geometry and photographic sampling.
  • Missing or zero values retain legacy rendering, while Individual Cells ignores the setting.
  • The new browser QA script needs small portability and setup fixes to run reliably from a fresh checkout.

Reviews (1) · Last reviewed commit: "Add bounded Cells edge scatter and edita..."

Comment thread tests/composition/editorial-studies-ui.mjs
Comment thread tests/composition/editorial-studies-ui.mjs Outdated
…roup failures

Media load callbacks now ignore replaced or removed passes and pending loads are cleared on disposal. Strict-mode pass failures are reported once at the originating pass instead of at every group boundary.
Publishing now drops every descendant of a hidden group and clears the
parentId of any retained layer (the audio source) whose parent was removed,
so the published scene passes hierarchy validation on reopen.
Cap the neighbor row and column search to two cells each side so the
worst-case cellAt count per fragment is 25 instead of unbounded in the
packed minimum-size, maximum-stroke configuration. Mirrored in the
runtime package.
…e on buttons

Clear the active paint layer when the layer stops being paintable (selection,
mode, visibility or lock change) so Paint never resumes without Edit Paint.
Only preventDefault on Space for non-interactive targets so focused buttons
and links still activate.
Create the .context artifact directory up front and pick the history shortcut modifier from the platform.
@git-chad
git-chad force-pushed the git-chad/v3-threshold-colors branch from 76a920f to 76efc85 Compare October 1, 2026 07:04
@git-chad
git-chad force-pushed the git-chad/v3-cell-editorial-studies branch from d064f33 to b3f0c7e Compare October 1, 2026 07:04
@git-chad
git-chad changed the base branch from git-chad/v3-threshold-colors to git-chad/shader-lab-v3-plan October 1, 2026 15:12
@git-chad
git-chad merged commit b3f0c7e into git-chad/shader-lab-v3-plan Oct 1, 2026
5 checks passed

This branch was successfully deployed

1 active deployment
Preview — b3f0c7e0 Deployed Oct 1, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant