Repository navigation
Add painted reveals to Photographic Cells - #161
Merged
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
7 tasks
 |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
…roup failures Media load callbacks now ignore replaced or removed passes and pending loads are cleared on disposal. Strict-mode pass failures are reported once at the originating pass instead of at every group boundary.
Publishing now drops every descendant of a hidden group and clears the parentId of any retained layer (the audio source) whose parent was removed, so the published scene passes hierarchy validation on reopen.
Cap the neighbor row and column search to two cells each side so the worst-case cellAt count per fragment is 25 instead of unbounded in the packed minimum-size, maximum-stroke configuration. Mirrored in the runtime package.
…e on buttons Clear the active paint layer when the layer stops being paintable (selection, mode, visibility or lock change) so Paint never resumes without Edit Paint. Only preventDefault on Space for non-interactive targets so focused buttons and links still activate.
git-chad
force-pushed
the
git-chad/v3-cell-regions
branch
from
October 1, 2026 07:04
2311e14 to
55f46d5
Compare
git-chad
force-pushed
the
git-chad/v3-cell-paint
branch
from
October 1, 2026 07:04
164cec7 to
73107b7
Compare
git-chad
changed the base branch from
git-chad/v3-cell-regions
to
git-chad/shader-lab-v3-plan
October 1, 2026 15:12
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Photographic Cells can now reveal areas chosen by painting. Layout → Paint adds Reveal/Erase, Brush Size, reversible Clear, and automatic editing on choosing Paint, plus Edit/Done controls to resume or finish. A faint source guide appears only while editing; the painted region retains photographic detail and uses the existing stepped geometry and perimeter outlines.
Coverage is stored as a bounded bit-packed mask and travels through project hydration, duplication, history, shader export and the runtime. Strokes commit as single undo actions; Escape, blur, capture loss and scene replacement cancel incomplete strokes. Canvas pan/zoom stays available, including a fix for Space accidentally activating a previously focused toolbar button.
The GPU mask texture is reused and uploaded only when coverage changes; moving source frames remain live. An opt-in decoded-video benchmark compares Rings, automatic Cells, Paint and combined passes. Its SwiftShader results identify Rings as the main cost in that software workload, not a native GPU or thermal diagnosis. Native sustained playback and encoded-video export validation remain in roadmap 7.2.
Validation:
bun run checkpasses (existing lint warnings only).bun run test:compositionpasses, including 178 Cells GPU cases and real hydration/history/export checks.bun tests/composition/cell-paint-ui.mjspasses: real pointer strokes, atomic undo/redo, erase/clear/cancellation, pan/zoom coordinate alignment, and actual.labexport/reopen.Stack: this PR → #160 (
git-chad/v3-cell-regions), ultimately into integration #150. No V3 merge into main until the plan is complete. The user accepted the painted reveal and requested automatic entry to editing; focused test and performance limits. Edge Scatter and fine-dot/color curation remain later work.Roadmap follow-up: the user requested customizable dark/light colors in the existing Threshold layer, preserving black/white defaults. Recorded as pending implementation in 2.5.1.