Repository navigation
feat(scaling): show proof history and witness generation as separate limits - #222
Open
0x00101010 wants to merge 3 commits into
Open
0x00101010 wants to merge 3 commits into
0x00101010 wants to merge 3 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #220 (
feat/scaling-limit-categories); will retargetmainafter #220 merges.Why
The bench's proof-node step now judges two limits separately and reports each with its own budget: proof history must run at least 2× real time (head lag is recorded only), and witness generation (
debug_executePayloadp99) has a 3 s budget. The page still applied its own hard-coded budgets (lag ≤ 10 blocks, ≤ 1 s) to one merged "Proof node" row, so passing runs showed as over budget and unranked.What
proof_nodestep outputs; no proof-node budget is hard-coded anymore. Runs from before the bench reported them show their lag and p99 with the budget as unknown, and stay unranked.≥(the bench underestimates throughput). Witness generation: ceiling ≈ run rate × budget ÷ p99, tagged Estimated (assumes linear scaling).Notes
/scaling/guardrailsswaps the head-lag row for proof history headroom; it has no screenshot here (only/scalingwas retaken), andfirstScreen.test.tsxcovers it.Evidence
Review: ready (one blocker fixed, re-reviewed) | high, 85% | deep (220 hand-written lines): claude-fable-5-1 + gpt-6-astra
/scaling, full page/scalingat 1280 px, from the running app. Synthetic data only: a copy of the synthetic fixture (network set tomainnet, the live archive-size fetch blocked) and a synthetic bench host served through Playwright with two 200 Mgas/s runs (mix: headroom 2.6×, p99 1400 ms; swaps: 3.4×, 900 ms).Not verified beyond CI otherwise.