Repository navigation
test(policy): remove POLICY_DISPATCH_FIX skip from dispatch_inactive - #242
Merged
Merged
Conversation
The unknown-selector dispatch test no longer needs the POLICY_DISPATCH_FIX opt-in, so it runs whenever fork mode is on. Drop the flag from the test and from LIVE_PRECOMPILE_TESTING.md so base/base CI needs no extra config. Co-authored-by: Toshi <toshi-noreply@coinbase.com>
rayyan224
requested review from
amiecorso,
eric-ships and
ilikesymmetry
as code owners
October 22, 2026 19:13
Interface Coverage✅ All interface functions have test coverage. |
📊 Forge Coverage (
|
| File | Lines | Stmts | Branches | Funcs |
|---|---|---|---|---|
| 🟡 B20FactoryLib.sol | 97.70% | 98.00% | 100.00% | 95.00% |
| 🔴 test/lib/ForceFeeder.sol | 0.00% | 0.00% | 100.00% | 0.00% |
| 🔴 test/lib/PrecompileProbe.sol | 0.00% | 0.00% | 0.00% | 0.00% |
| 🟢 MockActivationRegistry.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| 🟢 MockActivationRegistryStorage.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| 🟢 MockB20.sol | 100.00% | 99.68% | 100.00% | 100.00% |
| 🟢 MockB20Asset.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| 🟡 MockB20Factory.sol | 98.96% | 99.10% | 100.00% | 100.00% |
| 🟢 MockB20Stablecoin.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| 🟢 MockB20Storage.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| 🟢 MockBaseTime.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| 🟡 MockPolicyRegistry.sol | 100.00% | 99.58% | 97.78% | 100.00% |
| 🟢 MockPolicyRegistryStorage.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| Total | 97.14% | 97.51% | 98.21% | 97.07% |
Full report: download artifact. To browse locally: make coverage (runs forge coverage + genhtml + opens the HTML report).
✅ Fork tests: 795 passed, 0 failed, 13 skippedThe completed Denim suite passed. Skipped tests were not validated. |
meyer9
added a commit
to base/base
that referenced
this pull request
Oct 22, 2026
base/base-std#242 removes the flag from base-std, but the pinned Beryl and Cobalt tags, and Denim until its ref moves past that change, still skip the dispatch test without it. Amp-Thread-ID: https://ampcode.com/threads/T-f04cecba-e4dc-42c5-94de-8846dbf5444c Co-authored-by: Julian Meyer <julian.meyer@coinbase.com>
meyer9
approved these changes
Oct 23, 2026
meyer9
added a commit
to base/base
that referenced
this pull request
Oct 26, 2026
base/base-std#242 runs the policy dispatch-ordering test in live mode without POLICY_DISPATCH_FIX. Move Denim's base-std ref to its merge commit; the Beryl and Cobalt tags still read the flag. Amp-Thread-ID: https://ampcode.com/threads/T-f04cecba-e4dc-42c5-94de-8846dbf5444c Co-authored-by: Julian Meyer <julian.meyer@coinbase.com>
meyer9
added a commit
to base/base
that referenced
this pull request
Oct 26, 2026
Denim's base-std ref includes base/base-std#242, which runs the policy dispatch-ordering test without the flag. The Beryl and Cobalt tags predate that change, so the test stays skipped there; that is accepted rather than carrying the flag for two frozen refs. Amp-Thread-ID: https://ampcode.com/threads/T-f04cecba-e4dc-42c5-94de-8846dbf5444c Co-authored-by: Julian Meyer <julian.meyer@coinbase.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
POLICY_DISPATCH_FIXenv gate fromtest_dispatch_revert_unknownSelectorNotMaskedByActivation, so it runs whenever fork mode is on instead of being reported as skipped. Also drops the flag fromLIVE_PRECOMPILE_TESTING.md.This avoids adding extra config for the flag to base/base CI (see base/base#6154).
Testing:
forge test --match-path test/unit/PolicyRegistry/dispatch_inactive.t.solcompiles and skips in mock mode as before. Fork CI is the check that the live precompile passes this test.