Repository navigation
fix(deps): resolve cargo-deny RustSec advisories - #93
Merged
Merged
Conversation
cargo deny check began failing on base-anvil-fork once new RustSec advisories were published (2026-10-09 to 2026-10-23) against an unchanged lockfile. - rustls 0.23.45 -> 0.23.46, rustls-webpki 0.103.14 -> 0.103.16 (RUSTSEC-2026-0346/0347/0348/0349/0382) - webpki-roots / webpki-root-certs 1.0.9 -> 1.0.10 (RUSTSEC-2026-0381/0383) - tokio 1.53.1 -> 1.53.3 (RUSTSEC-2026-0386) - ctutils 0.4.2 -> 0.4.4, and commonware-* 2026.7.1 -> 2026.9.0 to drop ctutils 0.3.1 (RUSTSEC-2026-0385) - svm-rs / svm-rs-builds 0.5.26 -> 0.5.30 and soldeer-core / soldeer-commands =0.10.0 -> =0.12.1 so zip 4.6.1 and 8.6.0 are replaced by zip 9.0.5 (RUSTSEC-2026-0367/0368/0369) - chacha20 0.10.1 -> 0.10.2 (0.10.1 is yanked) - drop the RUSTSEC-2025-0172 ignore from deny.toml; zip-extract is no longer in the tree
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
deny / cargo deny checkfails on every PR againstbase-anvil-fork(red on #91 and #92, which merged with it red). All other CI checks on #92 passed (clippy, test all, test external, docs, doctest, crate-checks, forge-fmt, rustfmt, typos, shellcheck, CodeQL Analyze).The failure is not caused by the base/base pin bump. Between 541626f and 2549ee7
Cargo.lockonly changed thebase-*git source revs. The failing crates are unchanged. RustSec published new advisories against them between 2026-10-09 and 2026-10-23 and CI uses the latest advisory DB. The last green CI run on the repo was 2026-10-11, before most of them.Advisories reported by
cargo deny --all-features check all(reproduced locally with cargo-deny 0.19.4, identical to the CI log):Solution
Targeted lockfile bumps, plus two manifest-level moves where a dependent pinned the vulnerable major:
cargo update --precise--precise--precise--precise--precise^0.3.1), which has no fixed 0.3.x2026.7.0requirement; 2026.9.0 uses ctutils^0.4.2. Pulls chacha20poly1305 0.10.1 -> 0.11.0, poly1305 0.8 -> 0.9.1, aead 0.5.2 -> 0.6.1, universal-hash 0.5.1 -> 0.6.1zip ^9(0.5.27-0.5.29 use^8)zip ^4+ zip-extract. 0.12.1 useszip ^9and drops zip-extract. Same version upstream foundry pins. WorkspaceCargo.tomlchangedeny.toml: removed theRUSTSEC-2025-0172(zip-extract unmaintained) ignore. zip-extract is gone, so the entry only produced anadvisory-not-detectedwarning. No new ignores were added. The base/base pin andDEFAULT_BASE_UPGRADEare untouched. No Rust source changed.Verification (local, rust 1.96.0):
cargo deny --all-features check all:advisories ok, bans ok, licenses ok, sources okcargo check --workspace --all-targets: okcargo test -p foundry-evm-networks: okcargo test -p anvil --lib base: 4 passedcargo test -p forge --test cli -- soldeer: 11 passed (exercises the soldeer 0.12.1 upgrade)cargo fmt --check: okLeft as is:
cargo denystill prints warnings that do not fail the job: unmatched license exception/allowance (tiny-keccak,OpenSSL), 7 unmatchedallow-gitsources, and yankedclipboard-win 5.4.1/wnaf 0.14.0.Not addressed here: the scheduled
test-flakyandtest-isolateworkflows have failed every day since at least 2026-09-14, long before #91/#92. They fail on network-dependent tests (RPC free-plan limits, solc download, etherscan/blockscout). They are unrelated to cargo-deny and this PR.PR Checklist