Repository navigation
merge up to upstream commit 8e7b574 - #53
Merged
Merged
Conversation
keysym_from_name() calls CString::new(key).unwrap().
- Use a Vec instead of a HashMap - Update the recent_windows version to match the normal one, printing the duplicate bind
This intentionally introduces a new config parse error:
binds {
Alt_L { spawn "alacritty"; }
Alt+Alt_L { spawn "alacritty"; }
}
This used to parse before (only one of the binds worked though). Now
these are considered the same bind, so this config will error
accordingly.
There's a small behavior change: pressing a bind that is on a cooldown and has repeat=true won't start the key repeat (it used to). The reason is that for Press+Release keys it would make it annoying to track when the release bind should fire (only after the first repeated key rather than currently when it's recorded on press).
Remove all screenshot hardcoding in the code. Behavior changes: - Escape to close now works only when no modifiers are held. - Other screenshot binds like Ctrl+C or Space used to ignore the state of some modifiers like Super, they now need them released. - Repeat is disabled for screenshot binds, practically holding P won't repeatedly cycle the pointer. - Inside the screenshot UI, the screenshot binds take precedence over allowed configured binds (e.g. if you configured Ctrl+C to spawn, or binds with MouseLeft).
Arguably more semantically correct, and will avoid running some unnecessary loops in the future.
More semantically correct. If you have Escape on some xkb layer, why wouldn't it work to hit it?
See the comment in the code. First we search for modified because that's the symbol that was actually input. Fixes cases like Mod+odiaeresis binds falling back to a ASCII bind unnecessarily, or Mod+Shift+/ on a Russian layout with its \ / key. Then we search for layer-0 current layout, which makes non-ASCII binds case-insensitive too. Then we search for a layer-0 ASCII key on other layouts, but only if raw isn't ASCII itself. This is the required fallback for Russian binds. Another thing this commit changes is that dead keys now get ASCII fallback too.
Add a nested-show-host-cursor option in debug {} to restore showing the host cursor if desired.
For consistency, also for correct handling of pass-through release-only binds.
Not just modifier-triggered. For consistency with other compositors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a larger PR than usual because it had to resolve several merge conflicts regarding how both branches have made changes to how actions are treated (multi-action binds vs bounded actions)
Key fixes/resolutions:
Things that needed judgment: