Repository navigation
Conversation
Erasing the bib in the edit pane made useAthlete look up NaN, which toasted "not found". Only run the lookup for a real number; the required-bib check already blocks saving an empty bib. Closes #443 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #443
What
Erasing the Bib field in the edit pane made
useAthletelook upNaN, which showed a confusing "not found" toast.useAthletenow only runs its query when the bib is a real number. Saving with an empty bib is still blocked by the existing "Bib# is required" check.The name box shows "Unknown" while the field is empty, same as before.
Tests
No unit test. The change is a single
enabledguard on a React Query hook, and the renderer has no hook/DOM test setup. Lint and type check pass. Not yet checked manually in the app.🤖 Generated with Claude Code