Repository navigation
Conversation
Deleting a timing record left the athlete's Status.progress as it was, so a wrong bib kept its "Out" chip on the roster. Recompute progress after a delete, and for the old bib when an edit moves a record to a different bib. Closes #432 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #432
What
Logging a time recomputes the athlete's
Status.progress(the In / Out chip on the roster), but removing a time never did. A bib entered by mistake kept its Out ➠ chip after the record was deleted.The same thing happened when a wrong bib was fixed by editing the row's bib number: the new bib was recomputed, the old one was not.
Changes
deleteTimeRecordcallsSetProgressfor the deleted record's bibupdateTimeRecordalso callsSetProgressfor the previous bib when the bib changedTests
Two new
timingRecords-dbtests, written first and confirmed failing on develop:The full
src/main/databasesuite passes. The delete case was checked manually in the app.🤖 Generated with Claude Code