Repository navigation
Conversation
Hunks used to end only when a line started another state, such as a `commit ` header. Output from `git log -p` with a custom --pretty format (e.g. one starting with "Commit:") never produced such a line, so every following commit was drawn as lines of the previous hunk. The blank line git prints between commits was also drawn as a phantom numbered line at the end of each hunk. Now each hunk tracks the line counts from its header (also for combined diffs) and ends when they reach zero, letting a trailing "\ No newline at end of file" through. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017FPXTedgEC3D3TAaGpDdNe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hunks currently end only when a line starts another state, such as a
commitheader. That breaks in two ways:--prettyformats. With e.g.format.pretty = "Commit: %H%n…",git log -pnever prints a line starting withcommit, so every commit after the first is drawn as lines of the previous hunk.This tracks the line counts from each hunk header (
@@ -a,n +b,m @@, and the N+1 ranges of combined@@@headers) and ends the hunk once they are used up. A trailing\ No newline at end of filestill belongs to the hunk. The separator before acommitheader is kept when the previous hunk ended this way.Tests
Before, the second commit's header rendered as hunk lines:
After:
🤖 Generated with Claude Code Opus 5.5