Synchronize Feature Branch - #245
Merged
Merged
Conversation
…rn to vertical panel to show y-axis better
Updated ball drop notebook to use this interface.
Calibrators now pass in all arguments required by samplers in a quasi sampler-agnostic way, which should help if we want to allow for user-provided samplers.
All samplers now take the same four mandatory arguments with no default values in sight. This is the same interface that we would impose on user-provided samplers. Note that the fourth argument is a dictionary that contains all sampler-specific information. Therefore, this interface is sufficiently generic and flexible. The tools and test suite files in the tools folder are now simpler and cleaner as a result of these changes. I take that as a good sign that we are moving in the right direction. The ball drop notebook is now somewhat easier to read.
The final calibration in the fourth example is bad with a very low acceptance rate.
Last time this action ran it needed less than 5 minutes, so 10 should be a nice conservative value that won't waste too much runner time on texlive failures.
Don't let failed texlive installations run forever
Synchronize feature branch
Improve autocorrelation plot
…l pointers to documentation.
Simplify and clean calibrator interface
Synchronize Feature Branch
Test ran through successfully after fixing merge conflict issues.
Fix PTLMC gradient mismatched dimension
Synchronize sampler gradient fixes into feature branch
These contents are not necessarily correct. Rather, I am trying to determine what the content should be so that the inline sampler docs are complete, provide all technical information needed to users to help them make good decisions, and the express type expectations for arguments and user-provided functions.
The formatting rules could still use some improving.
…ace. This makes sense since the docs state that they are in the public interface. It also improves the readability of the sphinx API docs and resolves the appearance of "sampler()" three times in the RTD TOC.
Simplify/clean sampler interface & use
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mainupdate since this feature branch was last synchronized.