Simplify/clean sampler interface & use - #235
Open
jared321 wants to merge 15 commits into
Open
Conversation
Updated ball drop notebook to use this interface.
Calibrators now pass in all arguments required by samplers in a quasi sampler-agnostic way, which should help if we want to allow for user-provided samplers.
All samplers now take the same four mandatory arguments with no default values in sight. This is the same interface that we would impose on user-provided samplers. Note that the fourth argument is a dictionary that contains all sampler-specific information. Therefore, this interface is sufficiently generic and flexible. The tools and test suite files in the tools folder are now simpler and cleaner as a result of these changes. I take that as a good sign that we are moving in the right direction. The ball drop notebook is now somewhat easier to read.
The final calibration in the fourth example is bad with a very low acceptance rate.
17 tasks
Synchronize Feature Branch
Test ran through successfully after fixing merge conflict issues.
Synchronize sampler gradient fixes into feature branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pending tasks
mainbringmaininto this branch & resolve any conflictsTODOinshared_scenario.pyemudocs in `calibrator__init__should allow for shorteningemu : surmise.emulation.emulatortosurmise.emulatorsurmise.calibration.calibratornow have their shorted names or fix so that they do.We will not be making any similar interface changes for emulation currently, because the emulator takes a possible passthrough function.
Implementing lessons learned form last sampler branch and looking forward to allowing users to pass custom sampler to
calibratoras asamplerargument.PR Self-review