Skip to content

Feature: External Migration (Portal) - #398

Open
pingustar wants to merge 17 commits into
mainfrom
feature/vampireAttack
Open

Feature: External Migration (Portal)#398
pingustar wants to merge 17 commits into
mainfrom
feature/vampireAttack

Conversation

@pingustar

Copy link
Copy Markdown
Contributor

No description provided.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jun 2, 2022

Copy link
Copy Markdown

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: aeca98f
Status: ✅  Deploy successful!
Preview URL: https://d2073016.falafel.pages.dev

View logs

@ashachaf ashachaf changed the title Feature: Vampire Attack Feature: External Migration (Portal) Jun 2, 2022
@ashachaf

ashachaf commented Jun 2, 2022

Copy link
Copy Markdown
Contributor
  • always show both token symbols. if we dont have the image, use a placeholder
  • list should be based on pool token value. highest should be first.
  • missing notification on confirmation
  • approve is indicating lpTKN. consider using a better name (if available). for example, ETH/DAI pool.

@pingustar
pingustar marked this pull request as ready for review June 3, 2022 12:58
@pingustar
pingustar requested review from ashachaf and zavelevsky June 3, 2022 12:58
zavelevsky
zavelevsky previously approved these changes Jun 5, 2022

@zavelevsky zavelevsky left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ashachaf

ashachaf commented Jun 6, 2022

Copy link
Copy Markdown
Contributor
  • we might have inaccuracy with the numbers we show

image

image

please include a disclaimer: "Amount might vary on execution" and position it below the grey box (and above the CTA)

image

- [ ] add negative "-" before the value

image

when we show the amount in red, please add - below the value. currently: $154,207 updated: -$154,207
  • when migrating ETH-non supported TKN pair
    Confirm the non supported TKN is set to the user's wallet correctly

@ashachaf

ashachaf commented Jun 13, 2022

Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants