Repository navigation
Add swiftpmConfig.name for React Native SwiftPM autolinking - #201
Merged
Merged
Conversation
Owner
|
Thank you! |
balthazar
added a commit
that referenced
this pull request
Oct 29, 2026
…nking React Native 0.88 takes a library's SwiftPM product name from swiftpmConfig.name in package.json, falling back to the podspec name (react-native-zeroconf). The manifest's product is ReactNativeZeroconf, so the package failed to resolve. Same fix as #201 on 0.17. Co-authored-by: Christian Falch <christian.falch@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The library ships a Package.swift with product
ReactNativeZeroconf. React Native 0.88 SwiftPM autolinking looks for a product namedreact-native-zeroconfunless package.json setsswiftpmConfig.name, so the app fails at package resolution.This adds
swiftpmConfig.nameto package.json to selectReactNativeZeroconf. It has no effect on CocoaPods or Android.React Native 0.87 reads only the older
spmblock in react-native.config.js. This key matters from React Native 0.88 on.Test plan:
npx react-native spm add --deintegratecompleted.new Zeroconf()succeeded. No crash.