fix(tizen): drop the mpv-only playback settings from the TV - #3
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tizen plays through the native Capi backend —
Player()returnsPlayerTizen, and libmpv does not exist on the platform. But the settings UI still offered the tuning controls that exist only to reach mpv.Why each one is dead there
PlayerTizen.setPropertyacceptspauseandsub-visibilityand throwsUnsupportedErrorfor everything else, andVideoPlayerScreenalready wraps its whole property-writing block inif (!PlatformDetector.isTizen())(lines 1719-2016). So:mpv.confeditor:1981, inside the skipped block. mpv is never constructed.Player()discards thehardwareDecodingargument forPlayerTizen; thehwdecwrite at:1747is inside the skipped block.:1753, inside the skipped block. Capi has no filter chain — the same reason the tile already hides under ExoPlayer.setAudioDownmixwritesaudio-swresample-o/audio-channels. The Tizen device profile already pinsMaxAudioChannels: 2, so the server downmixes regardless.volume-maxamplification — and:2017pins that to 100 on Tizen.The two in-player toggles were worse than inert.
setAudioNormalizationandsetAudioDownmixboth route throughsetProperty, so on Tizen the write throws, gets logged by_commitWrite, and the switch snaps back — a control that visibly refuses to hold its value.The change
One capability gate, matching the existing
supportsDownloads()/supportsGamepads()/supportsSystemMediaControls()idiom on this branch:Six tiles in Playback settings and the two toggles in the in-player sheet ask it. Shader presets already gate correctly on
playerType == 'mpv', so they needed nothing.Behaviour off Tizen is unchanged:
supportsMpvTuning()is a compile-timetrueeverywhere else, and_hardwareDecodingTilestill shows for the Android/ExoPlayer path that genuinely reads the preference.Verification
flutter analyzeon the three changed files — clean.test/tizen/platform_test.dartextended, and it passes in both modes: the default pass asserts mpv tuning stays available, the--dart-define=TIZEN_BUILD=truepass asserts it is gone. That matches howscripts/tizen/check.shalready runs that directory twice.video_settings_sheet,playback_settings_screen,settings_screenandplatform_detectorsuites: 66 tests, all passing.Not verified on hardware: these tiles are removed, so there is nothing new to exercise on the TV beyond confirming they are absent.
AI assistance
Written with Claude Opus 5 via Claude Code, per CONTRIBUTING.md.
🤖 Generated with Claude Code