fix(tizen): drop the fullscreen toggle from the TV sidebar - #1
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
_showFullscreenTogglewas gated onPlatform.isWindows || Platform.isLinux. Tizen reports itself as Linux throughdart:io, so the fullscreen button was still rendering on the TV sidebar — at all four of its sites (side_navigation_rail.dart:685,:779,:1100, plus the nav-key list).A TV has no windowed surface to toggle, and
window_managerhas no Tizen implementation, so the button could only ever fail.Why this shape
This branch already routes the Tizen form factor through
PlatformDetector.isDesktopOS(), which excludes Tizen. Asking the same gate here keeps the decision in one place instead of adding a third platform literal — any future platform that is a TV-but-reports-desktop is then handled once. The!Platform.isMacOSterm preserves the existing intent recorded in the doc comment: macOS has the system green button, so it never wanted this toggle either.Behaviour on every other platform is unchanged:
isDesktopOS()isWindows || macOS || Linux, minus macOS, which is exactly the originalWindows || Linux.Verification
flutter analyze lib/widgets/side_navigation_rail.dart— cleanflutter test test/widgets/side_navigation_rail_test.dart— 20/20 passdart format --page-width 120appliedNot verified on real hardware — I have no Tizen device. The change is a pure compile-time gate, so the risk is confined to whether
TIZEN_BUILDis defined for the build, which this branch already handles.Credit
The Tizen platform-detection approach this builds on comes from edde746#1164 by @George-Fam, who ported the app to Tizen against real hardware (Samsung QN43LS01B, Tizen 10) — including a custom C#/Capi player backend and the Wayland focus fix for remote key delivery. This is a one-line gap in that groundwork, not a new idea.
AI assistance
Written with Claude Opus 5 via Claude Code, per CONTRIBUTING.md.
🤖 Generated with Claude Code