fix(supply-chain): honour HTTPS_PROXY on license registry routes - #117
Merged
Merged
Conversation
The registry fetcher built its own http.Transport without a Proxy func, so on a cluster whose only egress is an HTTP proxy every enrichment job recorded `unavailable` while the GitHub client (which honours the standard variables) kept working, and the inventory never showed a license. Use the process proxy configuration like every other outbound client. The private-address policy now resolves the route host explicitly, so a route to an internal address is still refused even though the socket only ever reaches the (private) proxy, and a direct connection still dials only the addresses that passed the check. Co-Authored-By: Claude <noreply@anthropic.com>
This was referenced Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
License enrichment built its own
http.Transportwithout aProxyfunc. On a cluster whose only egress is an HTTP proxy, every registry lookup recordedunavailablewhile the GitHub client (which honours the standard variables) kept working, so the Dependencies & Licenses page never showed a license.internal/supplychain/license/route.go: use the process proxy configuration (HTTPS_PROXY/NO_PROXY) like every other outbound client. The private-address policy now resolves the route host explicitly, so a route to an internal address is still refused even though the socket only ever reaches the (private) proxy; a direct connection still dials only the addresses that passed the check.resolvers_test.go:TestFetcherUsesEgressProxyruns a real CONNECT proxy, asserts exactly oneCONNECT example.com:443, and that a route resolving to10.0.0.5is rejected before any connection. Fails without the fix, passes with it.docs/operations.md,CHANGELOG.md: one entry each.User-visible behaviour
Registry routes work behind an egress proxy. No configuration change is required; deployments without a proxy are unaffected. A TLS-intercepting proxy needs its CA in
GRAPHNEST_SUPPLY_CHAIN_REGISTRY_<ECO>_CA_FILE(documented).Security
The private-address policy is unchanged in effect: it is now evaluated against the route host name in both the direct and proxied cases. Direct connections dial only policy-approved answers, so no rebinding window is introduced.
Verification