Repository navigation
Fix superscripts lost in the vendored protocol docs - #2
Merged
Merged
Conversation
The HTML-to-markdown conversion dropped <sup> tags, so powers of two became their digits run together. The length-encoded integer table read "251 | 216", "216 | 224", "224 | 264" — those bounds are 2^16, 2^24 and 2^64. Taken literally the table produces a broken int<lenenc> codec, which is the next thing phase 1 builds. Same damage in the packet splitting rule and the compressed packet page, where 2^24-1 had become 224-1. Found by re-running the conversion with <sup> and <sub> mapped to ^n and _n, then diffing; these three pages are the only ones affected out of 78.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The HTML-to-markdown conversion dropped
<sup>tags, so powers of two became their digits run together.page_protocol_basic_dt_integers.mdread:Those bounds are 2^16, 2^24 and 2^64. Taken literally the table produces an
int<lenenc>codec that is wrong for every value above 250 — and that codec is the next thing phase 1 builds.Same damage in two other pages, where
2^24-1had become224-1:page_protocol_basic_packets.md— the packet splitting rule, three placespage_protocol_basic_compression_packet.md— compressed packet sizesFound by re-running the conversion with
<sup>/<sub>mapped to^n/_nand diffing against the repo. These three pages are the only ones affected out of 78.