feat(#413): add map-prd-review skill and write_prd_review artifact function - #417
Merged
Conversation
…nction Implements issue #413: PRD/requirements-quality review before /map-plan. Changes: - Add `write_prd_review()` to `map_step_runner.py.jinja` (and rendered outputs): validates verdict, findings, blocking_questions, suggested_revisions; writes `.map/<branch>/prd-review.{json,md}` and updates artifact_manifest stage `prd_review`; enforces `needs_user_decision` requires at least one blocking question; rejects extra/missing fields and invalid severities - Add `prd_review` to ARTIFACT_STAGES tuple so `_set_manifest_stage` accepts it - Add `PRD_REVIEW_SCHEMA` to `schemas.py` - Add `map-prd-review/SKILL.md.jinja` skill with 11 review dimensions, verdict table, step-by-step workflow, troubleshooting, and argument-hint - Register `map-prd-review` in `skill-rules.json.jinja` (type=manual, task) - 13 new tests covering happy paths (all 4 verdicts), error cases, and structural validation; update skill count sentinel from 20 → 21 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Jn1BLjiPwPBbnTTtZDRQgd
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (12)
📝 WalkthroughWalkthroughAdds the ChangesPRD review workflow
Estimated code review effort: 4 (Complex) | ~45 minutes Possibly related issues
Possibly related PRs
Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/map-planwrite_prd_review()tomap_step_runner.py(and jinja source) with full validation of verdict, findings (11 dimensions), blocking_questions, and suggested_revisions/map-prd-reviewskill with verdicts table, workflow steps, troubleshooting sectionprd_reviewas a known artifact stage; addsPRD_REVIEW_SCHEMAto schemasTest plan
write_prd_reviewtests passmake checkpasses: ruff, mypy, pyright, pytest (4400 passed)make check-renderpasses: generated trees match templates_srcGenerated by Claude Code
Summary by CodeRabbit
New Features
Validation