Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: local-dev
name: graphrag-toolkit-rdf-dev

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can cause migration issues. Can you pin the names of the volumes too?

Update lines 58...:

volumes:
  # Pin explicit volume names so a Compose project rename does not orphan
  # existing data. With an explicit name Compose uses it verbatim (no project
  # prefix), so these always map to the same on-disk volumes regardless of the
  # top-level `name:`.
  neo4j_local_data_dev:
    name: local-dev_neo4j_local_data_dev
  neo4j_local_logs_dev:
    name: local-dev_neo4j_local_logs_dev
  pgvector_local_data_dev:
    name: local-dev_pgvector_local_data_dev

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Andrew, I have added the names for all three volumes and also I tested the rename path with an existing volume from the old project, and the renamed Compose project mounted the same volume instead of creating a new empty one 🙌

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

graphrag-toolkit-rdf-dev is out of step here — this stack runs neo4j-local + pgvector-local (not an RDF store), the SPARQL package that motivates "rdf" isn't in main yet, and it breaks the existing naming set (local-standard, local-dev, hybrid-standard, hybrid-dev).

Could we keep this PR as the permissions chore and leave the project as local-dev? The rdf naming would then land with the SPARQL store PR, where it matches reality.

services:
neo4j-local:
image: neo4j:5.25-community
Expand Down Expand Up @@ -56,6 +56,13 @@ networks:
driver: bridge

volumes:
# Pin explicit volume names so a Compose project rename does not orphan
# existing data. With an explicit name Compose uses it verbatim (no project
# prefix), so these always map to the same on-disk volumes regardless of the
# top-level `name:`.
neo4j_local_data_dev:
name: local-dev_neo4j_local_data_dev
neo4j_local_logs_dev:
name: local-dev_neo4j_local_logs_dev
pgvector_local_data_dev:
name: local-dev_pgvector_local_data_dev
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@ RUN conda install -n base -c conda-forge mamba -y && \
pip install --upgrade pip setuptools wheel build backports.tarfile && \
mkdir -p /tmp/pip-cache && chmod 777 /tmp/pip-cache && \
apt-get clean && \
rm -rf /var/lib/apt/lists/*
rm -rf /var/lib/apt/lists/* && \
fix-permissions "${CONDA_DIR}"

# Set pip cache to avoid warning: 'pip cache not writable'
ENV PIP_CACHE_DIR=/tmp/pip-cache
Expand Down