-
Notifications
You must be signed in to change notification settings - Fork 105
[CHORE] Fix local Jupyter permissions and rename the Compose project #492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| name: local-dev | ||
| name: graphrag-toolkit-rdf-dev | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Could we keep this PR as the permissions chore and leave the project as |
||
| services: | ||
| neo4j-local: | ||
| image: neo4j:5.25-community | ||
|
|
@@ -56,6 +56,13 @@ networks: | |
| driver: bridge | ||
|
|
||
| volumes: | ||
| # Pin explicit volume names so a Compose project rename does not orphan | ||
| # existing data. With an explicit name Compose uses it verbatim (no project | ||
| # prefix), so these always map to the same on-disk volumes regardless of the | ||
| # top-level `name:`. | ||
| neo4j_local_data_dev: | ||
| name: local-dev_neo4j_local_data_dev | ||
| neo4j_local_logs_dev: | ||
| name: local-dev_neo4j_local_logs_dev | ||
| pgvector_local_data_dev: | ||
| name: local-dev_pgvector_local_data_dev | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this can cause migration issues. Can you pin the names of the volumes too?
Update lines 58...:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Andrew, I have added the names for all three volumes and also I tested the rename path with an existing volume from the old project, and the renamed Compose project mounted the same volume instead of creating a new empty one 🙌