Repository navigation
Stop describing direct connections as deprecated - #2369
Merged
Merged
Conversation
kmcginnes
changed the title
kmcginnes
added this pull request to stack #2370
October 6, 2026 01:07
kmcginnes
force-pushed
the
undeprecate-direct-connections
branch
2 times, most recently
from
October 6, 2026 01:25
f232214 to
1bfc410
Compare
kmcginnes
marked this pull request as ready for review
October 6, 2026 01:32
kmcginnes
force-pushed
the
undeprecate-direct-connections
branch
from
October 6, 2026 01:32
1bfc410 to
a518e53
Compare
Direct connections stay a supported option. They are the only route for a database that the browser can reach but the server cannot, and for public endpoints that already allow cross-origin requests. The form label and tooltip, the error messages, the docs, the glossary and the unify-docker-image decision no longer say the option is deprecated or will be removed.
kmcginnes
force-pushed
the
undeprecate-direct-connections
branch
from
October 6, 2026 01:36
a518e53 to
faa0b7a
Compare
5 tasks done
kmcginnes
added a commit
that referenced
this pull request
Oct 6, 2026
## Description The connection method used to be a checkbox at the bottom of Advanced options, so the most consequential choice in the form was also the hardest to find, and the IAM fields appeared and vanished with nothing on screen explaining why. Direct connections are supported again as of #2369, so the form now presents both methods as a visible choice. ```diff <CreateConnection> Name Database URL Query Language + <ConnectionMethodField> "Connection method" + <MethodCard "Via proxy server"> selected by default + <IamSettings> Use AWS IAM authentication + AWS Region, Service Type + <MethodCard "Directly via browser"> <Collapsible "Advanced options"> Fetch Timeout Neighbor Expansion Limit - "Connect directly from the browser" checkbox ``` - Each card carries one sentence on what that method supports and what it gives up. The whole card is a click target. - The IAM settings sit in the proxy card, because only the proxy server can sign a request. Under "Directly via browser" they are hidden, and their values stay in the form but are not saved. - Checking IAM states that the Graph Explorer server signs requests with its own AWS credentials, not yours. - `RadioGroup` is a new primitive in `src/components`, wrapping the Radix radio group the way the other shadcn-derived components do. - The error messages, the Database URL validation message, the docs, both decision records and the glossary follow the new wording. ## Validation **Before:** the method was a checkbox labelled "Connect directly from the browser" at the bottom of Advanced options, and the recovery messages told the reader to uncheck it there. **After:**    New tests cover the default method, arrow-key selection, selecting by clicking a card, the signing notice, hiding and restoring the IAM settings, saving each method, the URL validation on the browser method, and editing a stored connection of either kind. **Verified live:** exercised in Safari against a local dev server. Clicking a card's title, description, padding or corners selects it, arrow keys move between the cards, and the IAM controls inside the proxy card stay usable without changing the selection. An empty region blocks save, a relative URL on the browser method shows its validation message, and editing a saved direct connection opens on "Directly via browser" with Advanced options collapsed. The dialog logged no console errors. ## Merge Danger **Door:** two-way **Impact:** connection form layout Stored and exported connections keep their shape, so reverting needs no migration. ## Related Issues - Follows #2369 - Related to #1622 - Related to #1327 - Related to #1625 ### Check List - [x] I confirm that my contribution is made under the terms of the Apache 2.0 license. - [x] I have verified `pnpm checks` passes with no errors. - [x] I have verified `pnpm test` passes with no failures. - [x] I have covered new added functionality with unit tests if necessary. - [x] I have updated documentation if necessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
USING_PROXY_SERVERandPUBLIC_OR_PROXY_ENDPOINTkeep working. Only the "will be removed" wording is dropped, andPUBLIC_OR_PROXY_ENDPOINTis documented as a legacy alias for the database URL of a direct default connection.Validation
pnpm checksandpnpm testpass.Merge Danger
Door: two-way
Blast Radius: docs, decision record, and user-facing wording
Related Issues
Related to #1622
Check List
pnpm checkspasses with no errors.pnpm testpasses with no failures.