Repository navigation
Stop marking direct connections in the connection list and details - #2368
Merged
Merged
Conversation
kmcginnes
changed the title
kmcginnes
added this pull request to stack #2370
October 6, 2026 01:07
kmcginnes
force-pushed
the
remove-direct-connection-marks
branch
2 times, most recently
from
October 6, 2026 01:25
324a7d2 to
9254323
Compare
kmcginnes
marked this pull request as ready for review
October 6, 2026 01:26
…2367) ## Description - The Database URL now comes before the Query Language, so the form reads in the order people have the information: where the database is, then what it speaks. - The IAM checkbox reads "Use AWS IAM authentication" instead of "AWS IAM Auth Enabled", so it describes what happens when it is checked. - The connection docs and the Neptune and Gremlin guides use the same order and wording. ## Validation - Tests look the checkbox up by its new name. - The field order is a layout change with no behavior to assert. - `pnpm checks` and `pnpm test` pass. ## Merge Danger **Door:** two-way **Blast Radius:** connection form layout and label Anything that finds the checkbox by its old accessible name needs the new one. ## Related Issues Follows the previous PR in this stack. ### Check List - [ ] I confirm that my contribution is made under the terms of the Apache 2.0 license. - [x] I have verified `pnpm checks` passes with no errors. - [x] I have verified `pnpm test` passes with no failures. - [x] I have covered new added functionality with unit tests if necessary. - [x] I have updated documentation if necessary.
The list row no longer adds Direct to its subtitle and the details pane no longer shows a Direct from browser label with a tooltip. The route a connection takes is not something the list needs to call out.
kmcginnes
force-pushed
the
remove-direct-connection-marks
branch
from
October 6, 2026 01:32
9254323 to
34c55f5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Validation
pnpm checksandpnpm testpass.Merge Danger
Door: two-way
Blast Radius: connection list and details display
Related Issues
Follows the previous PR in this stack.
Check List
pnpm checkspasses with no errors.pnpm testpasses with no failures.