Skip to content

core-js is a devDependency but is used in production code #2130

Description

@kmcginnes

Description

core-js is declared in devDependencies (packages/graph-explorer/package.json:97, ^3.49.0), but it's actually consumed by production application code: packages/graph-explorer/src/index.tsx:7 has import "core-js/full/iterator";, which polyfills the Iterator helpers proposal (Iterator.prototype.map/filter/take/drop/flatMap/etc.) and ships in the app bundle.

Since this import runs in the browser, core-js should be a regular dependencies entry, not a devDependencies entry — devDependencies are conventionally build/test-only and aren't guaranteed to be installed or resolved the same way in all consumption scenarios.

The import was added in commit 954882b3 (November 2024, #658) with no explanation of the dependency placement, so there's no known reason it was placed under devDependencies.

Expected Behavior

core-js should be moved from devDependencies to dependencies in packages/graph-explorer/package.json.


Important

Internal only — this issue is maintained by the core team and is not accepting external contributions.

No activity

Activity on this issue will appear here.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    dependenciesPull requests that update a dependency fileinternalSignals that the team will work on this issue internally.ready-for-agentfully specified, ready for an AFK agenttech debtIssues, typically tasks, that are mainly about cleaning up code that is problematic in some way

    Type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions