Replace manual --version validation with argparse choices using dynamic version discovery#410
Open
budaesandrei wants to merge 1 commit intoaws:mainfrom
Open
Conversation
…ic version discovery Added get_airflow_versions() to scan ./images/airflow/ for directories matching semver pattern (x.x.x). The --version argument now uses argparse choices instead of manual path existence checks, letting argparse handle validation and error messaging natively.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the manual path-existence validation for the
--versionargument increate_venvs.pywith argparse's built-inchoicesparameter, populated dynamically from the filesystem.Changes
get_airflow_versions()function that scans./images/airflow/and returns only directory names matching a semver pattern (^\d+\.\d+\.\d+$), so non-version folders (e.g. docs, temp directories) are excluded.--versionargument fromtype=strtochoices=available_versions, delegating validation to argparse.version_path.exists()check and associated error handling block, since argparse now handles invalid input with a clear error message listing valid choices.Testing
Verified the following scenarios:
--version 2.10.1(valid) — works as expected--versionomitted — creates venvs for all versions (unchanged behavior)--version invalid— argparse rejects with clear error listing available choices