Repository navigation
docs(aws-startup-advisor): name RDfA as an Azure discovery source - #474
Merged
leon1418 merged 2 commits intoOct 20, 2026
Merged
Conversation
aws#458 made a customer-supplied RDfA report a real Discover producer and left billing-export discovery unimplemented, but the skill description and plugin README still listed billing exports as a source and never mentioned RDfA.
leon1418
requested changes
Oct 20, 2026
leon1418
left a comment
leon1418
left a comment
Contributor
There was a problem hiding this comment.
[🤖 AI review 🤖]
One blocking correction at 6e93252: shorten the Azure skill description to the 1,024-character limit while retaining RDfA support and the billing-export limitation. The current 1,126-character value fails tools/validate_spec.py locally and in Build CI.
Validation: 41 Azure contract tests passed; both changed Markdown files passed lint; plugin parity and git diff --check passed. Re-run spec validation and the summary tests after shortening the description.
…r the 1024 limit
The RDfA naming edit pushed the azure-to-aws SKILL.md frontmatter description
to 1126 chars, failing the repo-root `build` check (`lint:spec`: description
over the 1024 limit). Trim to 1015 chars by dropping two redundant trigger
phrases ("move off Azure", "move Azure AI or agentic workloads to AWS") while
preserving the RDfA discovery-source mention (this PR's purpose) and the exact
"billing-export discovery is not implemented" wording the PR's own
test_azure_discovery_source_guidance.py pins. Root build and plugin CI
(467 tests) pass.
leon1418
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
#458 made a customer-supplied Resource Discovery for Azure (RDfA) report a real Discover producer, and Discover states that Azure Cost Management billing-export discovery is not implemented. The summaries a reader or agent loads first were not updated with that change:
azure-to-aws/SKILL.md's frontmatter still says Discover reads Terraform, the liveazCLI, app code, and billing exports, and never names RDfA.Fix
Describe the sources Discover actually reads.
Scope
Docs and one test. No Discover behavior changes. RDfA parsing from #458 is unchanged.
This overlaps the Azure guidance rewrite already on #459. If this lands first, #459 should rebase those sentences rather than restore the old "billing exports, and not RDfA" wording.
Validation
pytest tests/test_azure_discovery_source_guidance.py— 2 passed.markdownlint-cli2onSKILL.mdandREADME.md— 0 errors.Type of Change
Startup Advisor review checklist
By submitting this PR, I confirm that:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Made with Cursor