Skip to content

fix(aws-startup-advisor): reject migration reports that skip the decision core #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
herosjourney merged 12 commits into from
Oct 3, 2026
Merged

fix(aws-startup-advisor): reject migration reports that skip the decision core #396

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
432a3c8
fix(aws-startup-advisor): reject migration reports that skip the deci…
Oct 1, 2026
3428cc6
fix(report-validator): drop inert subtrees in _plain_text; correct st…
Oct 1, 2026
4141a53
fix(aws-startup-advisor): validate-migration-report — match short con…
Oct 2, 2026
346a8a2
fix(aws-startup-advisor): validate-heroku-migration-report — normaliz…
Oct 2, 2026
d42c1ac
docs(aws-startup-advisor): pass --aws-design on the Azure report gate…
Oct 2, 2026
e3d1bfe
fix(aws-startup-advisor): validate-migration-report — accept inline-l…
Oct 2, 2026
aa73aa4
test(aws-startup-advisor): declare would_flip_if in the Heroku decisi…
Oct 2, 2026
5398c82
test(aws-startup-advisor): cover migration-dir-gated scenario check i…
Oct 2, 2026
8a5c2b7
Merge branch 'main' into fix/report-decision-core-validator
herosjourney Oct 2, 2026
3df2623
Merge branch 'main' into fix/report-decision-core-validator
herosjourney Oct 3, 2026
6a79b88
fix: require distinct flip condition items
Oct 3, 2026
72559b3
fix: ignore hidden decision content
Oct 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ...startup-advisor/fixtures/heroku-decision-gate/after-decide-complete/estimation-infra.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,9 @@
],
"stay_if": [
"need Heroku DX indefinitely"
],
"would_flip_if": [
"A confirmed always-on traffic pattern would raise the AWS compute estimate materially."
]
},
"workshop": {
Expand Down
3 changes: 3 additions & 0 deletions ...artup-advisor/fixtures/heroku-decision-gate/retained-execution-pack/estimation-infra.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,9 @@
],
"stay_if": [
"need Heroku DX indefinitely"
],
"would_flip_if": [
"A confirmed always-on traffic pattern would raise the AWS compute estimate materially."
]
},
"workshop": {
Expand Down
6 changes: 6 additions & 0 deletions plugins/aws-startup-advisor/fixtures/migration-report-reference.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,12 @@ <h3>Stay entirely if</h3>
<li>Cost is the only metric and a dual-run period must be avoided</li>
</ul>

<h3>What would flip this</h3>
<ul class="compact">
<li>Single-AZ acceptable: AWS estimate drops further, strengthens go</li>
<li>BigQuery must cut over in the same window: defer for specialist evidence</li>
</ul>

<h3>Key decisions ahead</h3>
<ol class="compact">
<li>Target region and deployment model (Fargate vs EKS)</li>
Expand Down
Loading
Loading