Repository navigation
Conversation
…names, and fix the filter --help text - Under --dangerously-skip-permissions, Claude Code deny and ask rules still apply, so the agents guide (and both HTML bundles) now say so and suggest deny rules, instead of saying settings.json does not apply. - The README shows claude --agent konductor:konductor and /konductor:sop-<name> for the plugin, says plugin agents need agent-teams mode, and lists docs/telemetry-schema.json instead of docs/ as what the plugin ships. - skill-lookup-mcp --help says --skill-name-filter only excludes manifest-listed skills and that --agent-sop-filter has no manifest check, matching mcp/README.md.
…ode installs need agent-teams mode and tool permissions Specialists under mux and cmux run with -p, so an ask rule denies the call instead of prompting. The README's setup line now covers both Claude Code install paths and names tool permissions too. The filter help text and mcp/README.md name the manifest relative to the skills dir.
The help text now says a manifest-listed skill matching none of the patterns is excluded, with the manifest caveat attached, and the README row's double parenthetical is merged into one.
knihit
marked this pull request as ready for review
October 29, 2026 00:44
knihit
requested review from
georgebearden,
ihmaws,
shsenior and
simonkrol
as code owners
October 29, 2026 00:44
…llowups # Conflicts: # docs/index.html # docs/site/.user-guide.manifest # docs/site/user-guide.html
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Review findings on #119 and #126 that came in after they merged.
Docs:
docs/user-guide/agents.md(and both HTML bundles, through thesync-html-content.pyentry): the mux/cmux note saidsettings.json"does not apply" under them. Under--dangerously-skip-permissions, Claude Code still enforces deny rules ("Deny rules block in every mode, includingbypassPermissions"). Explicit ask rules aren't auto-approved either, but mux and cmux start each specialist with-p, where "the few calls that would still prompt are denied instead", so an ask rule denies the call. The note now says both and suggests deny rules for anything a dispatched agent must never do.README.md: the quick start addsclaude --agent konductor:konductor # Claude Code plugin, the SOP line adds/konductor:sop-<name>, and the marketplace line says plugin agents and SOPs use thekonductor:prefix, asdocs/user-guide/tasks/install-claude-plugin-marketplace.mddoes. A new line says either Claude Code install needs agent-teams mode and tool permissions, linking the setup steps. The standalone names stay. The project layout note listsdocs/telemetry-schema.json, which is all the plugin ships fromdocs/.MCP server:
skill-lookup-mcp --help: the--skill-name-filtertext keeps the rule (a manifest-listed skill matching none of the patterns is excluded), says other skills under that root always pass, and that a broken manifest turns the filter off with a WARN. The--agent-sop-filtertext no longer claims the same semantics. Both now matchmcp/README.md, which, like the help text, names the manifest relative to the skills dir (<target>/.konductor/manifestfor<target>/.konductor/skills).CHANGELOG: one bullet under
[Unreleased]/### Fixed.Merge after #105. The project layout note lists
NOTICE.txt, which the plugin ships only once #105 merges. Dropping it here and adding it back in #105 would churn both PRs, and #105 is ready to land, so this PR should merge after it.Type of Change
mcp/): help text onlyTesting
make -C mcp testpasses; clippy clean;rustfmt --checkclean onservers/skill-lookup/src/cli.rspython3 -m pytest -q tests/: 217 passed, 6 skippedbuild-user-guide.sh --checkpasses after recording;sync-html-content.pypreview exits 0make guide-check: one failure, also onmain(configinWITHDRAWN_COMMANDS)Checklist
Agents Affected
None. No agent spec, skill or SOP changed.