feat(batch): support FIFO entire batch failure override#8243
Open
rohan-patnaik wants to merge 1 commit into
Open
feat(batch): support FIFO entire batch failure override#8243rohan-patnaik wants to merge 1 commit into
rohan-patnaik wants to merge 1 commit into
Conversation
|
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
powertools-for-aws-oss-automation
Bot
added
the
size/M
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7596
Summary
This lets
SqsFifoPartialProcessoruse the existingraise_on_entire_batch_failureoption thatBatchProcessoralready supports.Why
Before this change, FIFO batch processing always raised
BatchProcessingErrorwhen every record ended up failed, even when callers wanted the Lambda partial failure response instead. That made the FIFO processor behave differently from the standard batch processor for the same option.Test plan
.venv/bin/python -m pytest tests/functional/batch/required_dependencies/test_utilities_batch.py -k 'sqs_fifo_batch_processor'.venv/bin/python -m ruff format --check aws_lambda_powertools/utilities/batch/sqs_fifo_partial_processor.py tests/functional/batch/required_dependencies/test_utilities_batch.py.venv/bin/python -m ruff check aws_lambda_powertools/utilities/batch/sqs_fifo_partial_processor.py tests/functional/batch/required_dependencies/test_utilities_batch.pyBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.