Add missing pytest-timeout to pyproject.toml and remove a duplicate pytest-cov entry#4
Open
RuifengHua wants to merge 1 commit into
Open
Conversation
conftest.py imports pytest_timeout unconditionally, but pytest-timeout is not listed in the [test] optional-dependencies. A fresh 'make install' followed by 'make test' then fails at conftest import with ModuleNotFoundError: No module named 'pytest_timeout'. Add pytest-timeout to the test dependency list, and remove a duplicate pytest-cov entry in the same list.
RuifengHua
force-pushed
the
fix-missing-pytest-timeout-dep
branch
from
68c8d6e to
f94d634
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test/conftest.pyimportspytest_timeoutunconditionally(code link), butpytest-timeoutis not listed in[project.optional-dependencies].testinpyproject.toml. A freshmake install+make testfails at conftest import withModuleNotFoundError: No module named 'pytest_timeout'.pytest-timeoutto thetestdependency list.pytest-coventry in the same list.Test plan
make installnow installspytest-timeoutinto the venv.python -c "import pytest_timeout"succeeds.conftest.pygets past theimport pytest_timeoutline (previously iterrored here before any tests could be collected).
Note: additional issues currently block a full test run from a fresh public clone (missing
test/utils/scripts/andperf_analysis_private, unregistered pytest plugin, and annkisimulate API mismatch). Filing those separately; this PR addresses only the missingpytest-timeoutdependency.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.