Skip to content

fix: let the integ credentials outlive the CodeBuild build they poll #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andychoquette merged 1 commit into from
Sep 23, 2026
Merged

fix: let the integ credentials outlive the CodeBuild build they poll #97

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .github/workflows/reusable_integration_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,13 +34,21 @@ jobs:
id-token: write
contents: read
steps:
# aws-codebuild-run-build polls the build with these credentials, so the session has to
# outlive the build, not just start it. The default is 1 hour and integ builds already run
# ~48 min on mainline and ~94 min against a tag, so the poller was dying mid-build with
# "The security token included in the request is expired" and failing the job while the
# build itself went on to succeed. Every *_IntegOIDCRole allows 10800s, so this needs no
# IAM change -- but configure-aws-credentials fails fast if a role's MaxSessionDuration is
# lower, so any new caller's role must allow it too.
- name: Configure AWS credentials for release
if: ${{inputs.environment == 'release'}}
uses: aws-actions/configure-aws-credentials@7474bc4690e29a8392af63c5b98e7449536d5c3a # v4.3.1
with:
role-to-assume: ${{ secrets.AWS_CODEBUILD_RELEASE_INTEG_ROLE }}
aws-region: us-west-2
mask-aws-account-id: true
role-duration-seconds: 10800

- name: Configure AWS credentials for mainline
if: ${{inputs.environment == 'mainline'}}
Expand All @@ -49,6 +57,7 @@ jobs:
role-to-assume: ${{ secrets.AWS_CODEBUILD_MAINLINE_INTEG_ROLE }}
aws-region: us-west-2
mask-aws-account-id: true
role-duration-seconds: 10800

- name: Run Integration Tests
uses: aws-actions/aws-codebuild-run-build@7e46c3fa1c1f217e26a73712796b1f78938b534b # v1.0.18
Expand Down
Loading