Skip to content

pyproject: Revert the required setuptools to >=61.0 - #175

Open
ldoktor wants to merge 1 commit into
avocado-framework:mainfrom
ldoktor:requirements
Open

pyproject: Revert the required setuptools to >=61.0#175
ldoktor wants to merge 1 commit into
avocado-framework:mainfrom
ldoktor:requirements

Conversation

@ldoktor

@ldoktor ldoktor commented Aug 10, 2026

Copy link
Copy Markdown
Collaborator

while bumping the setuptools for testing we also increased our minimal setuptools for deployment, which is not required and blocks deployment on python <3.10 which we still support. Revert the minimum back to the 61.0.

Summary by CodeRabbit

  • Chores
    • Improved compatibility with environments using older supported versions of the build tooling.

while bumping the setuptools for testing we also increased our minimal
setuptools for deployment, which is not required and blocks deployment
on python <3.10 which we still support. Revert the minimum back to the
61.0.

Signed-off-by: Lukáš Doktor <ldoktor@redhat.com>
@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown

Review Change Stack

Walkthrough

The build configuration lowers the minimum required setuptools version from 83.0.0 to 61.0. The setuptools-scm requirement remains unchanged.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the change to restore the minimum setuptools requirement to >=61.0.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@pyproject.toml`:
- Line 2: Update the setuptools requirement in requirements-travis.txt to remain
installable on the Python 3.x versions used by the ci workflow, either by adding
a Python-version marker or selecting a compatible upper-bound pin; preserve
setuptools-scm and ensure Python 3.8/3.9 do not resolve setuptools 83.0.0.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 6d4be9ca-df5f-47c2-96a6-4dec0d009e1f

📥 Commits

Reviewing files that changed from the base of the PR and between fe039a8 and afd6d27.

📒 Files selected for processing (1)
  • pyproject.toml

Comment thread pyproject.toml
@imammedo

Copy link
Copy Markdown

Tested on RHEL 9.9 (Python 3.9.25):

Upstream main (PR #174 merged, setuptools>=83.0.0):

  • pip3 install . → FAILS: ERROR: No matching distribution found for setuptools>=83.0.0 (setuptools 83+ requires Python >=3.10)
  • import aexpectModuleNotFoundError
  • avocado vt-bootstrapDistributionNotFound: The 'aexpect' distribution was not found
  • KAR Bootstrap.sh → fails at aexpect install step

This PR (revert to setuptools>=61.0):

  • pip3 install . → Successfully installed aexpect-1.8.0
  • import aexpect → OK
  • avocado vt-bootstrap → OK
  • KAR Bootstrap.sh → completes successfully

The breakage affects all RHEL 9 / CentOS Stream 9 users running avocado-vt with aexpect from source.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants