pyproject: Revert the required setuptools to >=61.0 - #175
Conversation
while bumping the setuptools for testing we also increased our minimal setuptools for deployment, which is not required and blocks deployment on python <3.10 which we still support. Revert the minimum back to the 61.0. Signed-off-by: Lukáš Doktor <ldoktor@redhat.com>
WalkthroughThe build configuration lowers the minimum required Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@pyproject.toml`:
- Line 2: Update the setuptools requirement in requirements-travis.txt to remain
installable on the Python 3.x versions used by the ci workflow, either by adding
a Python-version marker or selecting a compatible upper-bound pin; preserve
setuptools-scm and ensure Python 3.8/3.9 do not resolve setuptools 83.0.0.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 6d4be9ca-df5f-47c2-96a6-4dec0d009e1f
📒 Files selected for processing (1)
pyproject.toml
|
Tested on RHEL 9.9 (Python 3.9.25): Upstream main (PR #174 merged, setuptools>=83.0.0):
This PR (revert to setuptools>=61.0):
The breakage affects all RHEL 9 / CentOS Stream 9 users running avocado-vt with aexpect from source. |
while bumping the setuptools for testing we also increased our minimal setuptools for deployment, which is not required and blocks deployment on python <3.10 which we still support. Revert the minimum back to the 61.0.
Summary by CodeRabbit