Repository navigation
Upgrade to DuckDB v2.0.0 - #12
Merged
Merged
Conversation
Bump duckdb submodule to v2.0.0 (d54cbbe) and extension-ci-tools to the v2.0-cyanoptera tip (b8d325c); target v2.0.0 in MainDistributionPipeline.yml and Release.yml. Adapt to v2.0 C++ API changes: - ClientContext::GetParserOptions() is private; construct Parser(context). - BoundStatement::names is vector<Identifier>; convert via GetIdentifierName(). - named_argument_map_t is keyed by Identifier; look up with Identifier(name). - TableFunction::named_parameters is gone; declare keyword-only parameters on the signature. They get NULL defaults so they stay optional (keyword-only parameters without a default are required in v2.0), and FindParam already treats NULL as "not passed". Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
duckdbsubmodule to v2.0.0 (d54cbbe) andextension-ci-toolstov2.0-cyanoptera(b8d325c, the v2.0 counterpart ofv1.5-variegata).v2.0-cyanopterainMainDistributionPipeline.ymlandRelease.yml; note inRELEASE_NOTES.md.C++ API changes in v2.0
Parser(context.GetParserOptions())— now privateParser(context)BoundStatement::nameswasvector<string>vector<Identifier>→GetIdentifierName()named_parameters.find(string)Identifier→find(Identifier(name))TableFunction::named_parameters[...] = type— removedfun.GetSignature().AddKeywordOnly(name, type, Value())Keyword-only parameters without a default are required in v2.0, so each one gets a NULL default.
FindParamalready treats NULL as absent, so behavior is unchanged, including the extension's own "pk is required" error.User-visible differences:
table_diff(col0 VARCHAR, col1 VARCHAR, /, *, pk ANY, …).PK := 'id'works).Test plan
make releaseagainst v2.0.0 builds cleanlymake test: 10/10 test files passduck_diff.duckdb_extensioninto the v2.0.0 shell;table_diff/table_diff_summaryreturn correct results🤖 Generated with Claude Code