Repository navigation
fleet11: hold the SEP v5 ABI and the #628 driver change until their prerequisites ship - #660
Closed
RyanTheTide wants to merge 2 commits into
Closed
RyanTheTide wants to merge 2 commits into
RyanTheTide wants to merge 2 commits into
Conversation
The enrolment guard series (f70f1ac and follow-ups) moved the SEP biometric interface to version 5 and grew sep_bio_enrol_start from 136 to 144 bytes. Every packaged libfprint and aurora-sep still speaks version 4 and checks the version for equality, so on a kernel with the series aurora-sep-ready and fprintd skip themselves and Touch ID is gone on every machine. The matching libfprint change is still a draft (aurora-sep-userspace#3). Put the SEP driver and its UAPI header back to the version 4 interface that integration/aurora ships. The guard can return together with the version 5 libfprint and the aurora-sep sensor check. Assisted-by: LLM Signed-off-by: Ryan Murray <ryan@aurorasilicon.org>
…e J616s DT has it This reverts commit 3db9b1f for the fleet kernel. The commit lets DISPEXT1_SYS on the J616s register below both of its parents. Its own pull request (#628) says the Stage 2 DTB has to carry the dcpext1 power-domains first; without them genpd sees DISPEXT1_FE as unused and turns it off under the running dcpext1. The J616s still runs the old Stage 2 DTB, and a kernel with this commit never came back from two one-shot boots there (it fell back to the previous kernel both times). Keep the old behaviour, which only logs the -22 for power-controller@490, until the J616s Stage 2 DTB is refreshed. Assisted-by: LLM Signed-off-by: Ryan Murray <ryan@aurorasilicon.org>
Contributor
Author
|
Superseded by the fleet12 carry (https://github.com/aurora-silicon/linux/tree/fleet12/carry-20261031). Touch ID v5 shipped, so the SEP v4 hold is gone, and the #628 driver revert is carried per fleet build until the Stage 2 DTBs are refreshed. This hold branch was never meant to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fleet11 (aurora-wip 8348f82) had two regressions against fleet10 on real hardware. This branch is the exact source of the kernel now on the Neo and the J616s (
7.3.0-aurora-fleet11b, ab3a90c). Each commit holds back one merged change until the thing it depends on has shipped. Draft because each one is a decision for Ryan, not a fix to merge as is.1. SEP biometric ABI v5 (f70f1ac and follow-ups)
The series moves
SEP_BIO_IFACE_VERSIONfrom 4 to 5 and growssep_bio_enrol_startfrom 136 to 144 bytes. Every packaged userspace still speaks v4 and compares the version for equality:aurora-sep-sensor-present(fedora 1-14, alarm-aurora, nixos-aurora) and the libfprint SEP patch. On the Neo with plain fleet11, GET_INFO returned version 5, soaurora-sep-readyandfprintdskipped themselves (ExecConditionfailed) and Touch ID was gone. The kernel side was fine ("restored 3 enrolled identities").The v5 libfprint is still the draft aurora-silicon/aurora-sep-userspace#3, and the convergence report already listed this series as not ready for the same reason. The commit puts the SEP driver files and the UAPI header back to what integration/aurora ships (v4). Drop it once the v5 libfprint and a sensor check that accepts 5 are packaged on all three distros.
2. #628 driver commit on the J616s (3db9b1f)
#628 says the J616s Stage 2 DTB must carry its DT commit (dcpext1 and its DARTs and mailbox get
power-domains = <&ps_dispext1_fe>) before a kernel with its driver commit boots there. The J616s still runs the old Stage 2 DTB. A fleet11 kernel with the driver commit did not come back from two one-shot boots: both times GRUB fell back to fleet10 about 25 s later than a normal reboot, which fits an early panic pluspanic=10. The same image without the driver commit booted at once. The revert keeps the old behaviour (the -22 for power-controller@490 is still logged) until the J616s Stage 2 DTB is refreshed.Testing (both machines, full dmesg in
reports/fleet11-20261031/)clk_ignore_unused pd_ignore_unused idle=wfi arm64.nowfxt, then default: AVE H.264 and HEVC 1080p 300/300 frames through ffmpeg and GStreamer, v4l2-compliance 48/48, no-p 3lines, no sync_state lines, Wi-Fi and BT through the DT bootstrap, ISP camera 60 frames, Touch ID with 3 enrolled fingers, admac and i2c runtime-suspended after idle with audio and the MTP keyboard still there, 3 of 3 rtcwake cycles, aurora-diag check against the fleet10 snapshot passes.🤖 Generated with Claude Code