Skip to content

arm64: dts: apple: t8132-j713: Hold AOP messages in system sleep (depends on #820, #831) - #450

Merged
erykwieliczko merged 1 commit into
aurora-silicon:integration/aurorafrom
erikwb:j713/aop-mbox-sleep
Nov 4, 2026
Merged

erykwieliczko merged 1 commit into
aurora-silicon:integration/aurorafrom
erikwb:j713/aop-mbox-sleep

Conversation

@erikwb

@erikwb erikwb commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor

Holds the J713 AOP's once-a-second report in its mailbox during suspend-to-idle, so the report no longer wakes the CPUs.

Depends on #820 and #831.

This was split out of the suspend-to-idle series (first #449, now #831), because that series doesn't depend on the AOP series. Rebased from the closed #434 onto #820, so the AOP commits are carried only once. The commit itself is unchanged.

Commit

  • arm64: dts: apple: t8132-j713: Hold AOP messages in system sleep

Testing

On the J713, on integration/aurora 41c4055 with #820, the suspend-to-idle series (now #830 and #831), #432 and #429:
over 222 s of s2idle, the AOP mailbox (390608000.mailbox-recv) took 3 interrupts. It took 10 in the first 10 s awake after resume.

Again with the whole J713 PR stack (#830–#833, #819/#820, #531, #825): over 82 s of s2idle, the AOP mailbox took 5 interrupts.

Earlier, with the suspend-to-idle series (then #449) on 26.6.2 firmware: over 112 s of s2idle, the AOP mailbox (390608000.mailbox-recv) took 3 interrupts, against 946 in 938 s without the flag. The AOP audio worked after resume.

This change was developed and tested by Claude (Anthropic), working with me on the J713.

@RyanTheTide

RyanTheTide commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor

This head adds the AOP mailbox hold flag only on J713. The reported 112-second s2idle run and working AOP audio after resume are the board evidence. The parent commits from #434 are already part of this branch and must be applied only once.

The stacked kernel at 5b6f5515e2f8 passed both full universal and Fedora-base WERROR builds (Image, modules and DTBs); both preserve all 131 common-config settings. ARM64 16 KiB KUnit passed 275/275. DCP host tests passed 63/63, and the PMGR and radio SID checks passed. The M4 host suite has the same five failing groups as the pinned base (18/23 on each); the AFKv2 HPD harness also fails on both. These are recorded failures, not a full host-suite pass. All six T8132 DTBs were checked: 13 schema diagnostics against 11 on the base, with exactly two new DCP dma-noncoherent binding errors from #429. The seven targeted binding checks passed. These software gates do not replace the required shared-code boots.

No separate issue found in the one-line follow-up. Merge after both #434 and #449. It inherits #449's lost-retention review hold and the combined kernel's shared-code boot requirement.

@erikwb
erikwb force-pushed the j713/aop-mbox-sleep branch from 5d519c2 to 1bee5ac Compare November 1, 2026 23:57
@erikwb erikwb changed the title arm64: dts: apple: t8132-j713: Hold AOP messages in system sleep (depends on #434, #449) arm64: dts: apple: t8132-j713: Hold AOP messages in system sleep (depends on #820, #449) Nov 1, 2026
@erikwb erikwb changed the title arm64: dts: apple: t8132-j713: Hold AOP messages in system sleep (depends on #820, #449) arm64: dts: apple: t8132-j713: Hold AOP messages in system sleep (depends on #820, #831) Nov 2, 2026
The AOP sends a report every second; hold it in the mailbox across
suspend-to-idle instead of waking the system.

Signed-off-by: Erik Bourget <erik@ebourget.net>
@erykwieliczko

Copy link
Copy Markdown
Member

Merging, no changes. This comment is from Claude Opus 5.5, working for Eryk, not from Eryk himself.

Rebased and force-pushed, as Erik agreed. #820 and #831 are in, so this is now just its own commit, unchanged.

Testing

  • The DTB has apple,hold-rx-in-sleep on the AOP mailbox.
  • It was in the kernel for the suspend-to-idle cycle on Eryk's J713 described in J713 (M4 MacBook Air): suspend-to-idle #831.
  • Built together with the rest of this batch on integration/aurora (arm64: Image, modules, DTB).

🤖 Written by Claude Opus 5.5 (in Claude Code) for Eryk.

@erykwieliczko
erykwieliczko merged commit 62807db into aurora-silicon:integration/aurora Nov 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants