Repository navigation
arm64: dts: apple: t8132-j713: Hold AOP messages in system sleep (depends on #820, #831) - #450
Conversation
|
This head adds the AOP mailbox hold flag only on J713. The reported 112-second s2idle run and working AOP audio after resume are the board evidence. The parent commits from #434 are already part of this branch and must be applied only once. The stacked kernel at No separate issue found in the one-line follow-up. Merge after both #434 and #449. It inherits #449's lost-retention review hold and the combined kernel's shared-code boot requirement. |
5d519c2 to
1bee5ac
Compare
The AOP sends a report every second; hold it in the mailbox across suspend-to-idle instead of waking the system. Signed-off-by: Erik Bourget <erik@ebourget.net>
|
Merging, no changes. This comment is from Claude Opus 5.5, working for Eryk, not from Eryk himself. Rebased and force-pushed, as Erik agreed. #820 and #831 are in, so this is now just its own commit, unchanged. Testing
🤖 Written by Claude Opus 5.5 (in Claude Code) for Eryk. |
1bee5ac to
7a3478e
Compare
Holds the J713 AOP's once-a-second report in its mailbox during suspend-to-idle, so the report no longer wakes the CPUs.
Depends on #820 and #831.
aop_mboxnode this commit sets the flag on. The first 21 commits here are ASoC: apple: J713 (M4 MacBook Air) microphones, headphone jack and speakers #820's; only the last commit is new.apple,hold-rx-in-sleep(binding and mailbox driver), as part of the J713 suspend-to-idle series. Until it lands, the flag is inert.This was split out of the suspend-to-idle series (first #449, now #831), because that series doesn't depend on the AOP series. Rebased from the closed #434 onto #820, so the AOP commits are carried only once. The commit itself is unchanged.
Commit
Testing
On the J713, on integration/aurora 41c4055 with #820, the suspend-to-idle series (now #830 and #831), #432 and #429:
over 222 s of s2idle, the AOP mailbox (
390608000.mailbox-recv) took 3 interrupts. It took 10 in the first 10 s awake after resume.Again with the whole J713 PR stack (#830–#833, #819/#820, #531, #825): over 82 s of s2idle, the AOP mailbox took 5 interrupts.
Earlier, with the suspend-to-idle series (then #449) on 26.6.2 firmware: over 112 s of s2idle, the AOP mailbox (
390608000.mailbox-recv) took 3 interrupts, against 946 in 938 s without the flag. The AOP audio worked after resume.This change was developed and tested by Claude (Anthropic), working with me on the J713.