Replace legacy localization and adapter with VKS GICP interface - #18
Open
FieldDiTian wants to merge 2 commits into
Open
FieldDiTian wants to merge 2 commits into
FieldDiTian wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
gicp_localization/with the currentgicp_interface/package and remove the outdated Atlasadapter/fromucb-roar. The imported package tree exactly matchesairacingtech/gicp_interfacecommit715f7ed, preserving its car-tested Laguna configuration and current standalone/component interfaces.The workspace now uses the existing
/vks/imu,/vks/filtered_odom, and/vks/wheelsinputs for vehicle localization. Remove the adapter-dependentscripts/prep_bag.pyworkflow: localization replays existing bags directly, and GLIM reads existing bags directly throughglim_rosbag. The existing GLIM configuration generator now defaults to VKS IMU and Odometry inputs; no bag normalization or merge stage is required.Integration changes:
dliometapackage to depend ongicp_interface, remove both obsolete dependencies, and declare its ament build dependency.GICP_plusplus; mapping algorithm code is unchanged.small_gicpandrace_msgs, and the imported package's topics, QoS, frames, tuning, and installed profile alias.Validation on the combined workspace:
gicp_interface,gicp_plusplus,glim,glim_ext,glim_ros, anddlio./vks/imuand/vks/filtered_odomwithnav_msgs/msg/Odometry.715f7ed; removed packages/preparation script are absent; diff checks pass.