Skip to content

Replace legacy localization and adapter with VKS GICP interface - #18

Open
FieldDiTian wants to merge 2 commits into
augcog:ucb-roarfrom
FieldDiTian:codex/ucb-roar-gicp-interface
Open

FieldDiTian wants to merge 2 commits into
augcog:ucb-roarfrom
FieldDiTian:codex/ucb-roar-gicp-interface

Conversation

@FieldDiTian

@FieldDiTian FieldDiTian commented Sep 18, 2026

Copy link
Copy Markdown

Replace gicp_localization/ with the current gicp_interface/ package and remove the outdated Atlas adapter/ from ucb-roar. The imported package tree exactly matches airacingtech/gicp_interface commit 715f7ed, preserving its car-tested Laguna configuration and current standalone/component interfaces.

The workspace now uses the existing /vks/imu, /vks/filtered_odom, and /vks/wheels inputs for vehicle localization. Remove the adapter-dependent scripts/prep_bag.py workflow: localization replays existing bags directly, and GLIM reads existing bags directly through glim_rosbag. The existing GLIM configuration generator now defaults to VKS IMU and Odometry inputs; no bag normalization or merge stage is required.

Integration changes:

  • Update the dlio metapackage to depend on gicp_interface, remove both obsolete dependencies, and declare its ament build dependency.
  • Retain GLIM and GICP_plusplus; mapping algorithm code is unchanged.
  • Rewrite the root and GLIM READMEs for the current build, launch, direct-bag, calibration, and ENU-export workflow. Mark historical review/experimental instructions so they do not override the new setup.
  • Preserve the existing dependency environment, including external small_gicp and race_msgs, and the imported package's topics, QoS, frames, tuning, and installed profile alias.

Validation on the combined workspace:

  • All six packages built successfully: gicp_interface, gicp_plusplus, glim, glim_ext, glim_ros, and dlio.
  • Existing tests: 24 passed, 0 errors, 0 failures, 0 skipped.
  • Package discovery resolves all six to this worktree's install directory.
  • The imported standalone launch loads a synthetic PCD with the Laguna profile and shuts down cleanly.
  • The GICP component loads with intra-process communication enabled and advertises the expected Odometry type and BEST_EFFORT reliability. DDS discovery does not expose the configured history depth on this host; keep-last(100) remains verified in the unchanged source.
  • Generated mapping configuration selects /vks/imu and /vks/filtered_odom with nav_msgs/msg/Odometry.
  • The imported GICP tree exactly matches 715f7ed; removed packages/preparation script are absent; diff checks pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant