Repository navigation
Conversation
Adding a book to a series needed the ✓ in the series row; Save Changes only saved the text fields and dropped a series that was picked but not confirmed. That was easy to miss, most of all after adding a book from Z-Library, where the editor picks the series itself: four books added that way ended up in no series. Save now adds the picked series (with its number) first, and stays open with the error if that fails.
Owner
Author
|
Folded into #51 as a new commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In the book editor, a series is only assigned when you press the ✓ in the series row. Save Changes saved the text fields and silently dropped a series that was picked but not confirmed.
That was easy to miss, especially when adding from Z-Library, where the editor fills in the series by itself. Four books added that way today (Beneath the Dragoneye Moons 1–4) ended up in no series, even though the series was created. The live logs show
POST /api/seriesand thePATCHes, but noPOST /api/series/{id}/books/{book}.Fix
Testing
POST /api/series/4/books/b1?sequence=2before thePATCH. It fails on the old editor and passes with the fix.