Skip to content

chore: Update dependencies and expand test coverage - #46

Open
atorch wants to merge 4 commits into
masterfrom
dependency-updates-2026
Open

atorch wants to merge 4 commits into
masterfrom
dependency-updates-2026

Conversation

@atorch

@atorch atorch commented Mar 7, 2026

Copy link
Copy Markdown
Owner
  • Bump minSdkVersion from 19 to 21
  • Migrate mXparser from v4.2.0 (local JAR) to v6.1.0 (Maven)
  • Update AndroidX libraries to latest stable versions
  • Update Kotlin from 1.7.10 to 2.2.20
  • Add comprehensive test coverage for math parser functionality

- Bump minSdkVersion from 19 to 21
- Migrate mXparser from v4.2.0 (local JAR) to v6.1.0 (Maven)
- Update AndroidX libraries to latest stable versions
- Update Kotlin from 1.7.10 to 2.2.20
- Add comprehensive test coverage for math parser functionality

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR modernizes the Android app’s dependency stack (including the math parser) and expands unit tests around mathematical expression parsing/answer checking.

Changes:

  • Bump minSdkVersion to 21 and update several AndroidX/Material dependencies.
  • Migrate mXparser usage from a local JAR to the Maven artifact (MathParser.org-mXparser:6.1.0) and update the in-app string referencing the parser version.
  • Add a broad set of new unit tests covering additional math-parser inputs (percentages, constants, spacing, equivalences, etc.).

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.

File Description
app/build.gradle Updates min SDK and swaps mXparser from local JAR usage to a Maven dependency; refreshes AndroidX/Material/Kotlin stdlib versions.
app/src/test/java/atorch/statspuzzles/AnswerCheckerTest.java Adds extensive new unit coverage for expression formats and constants supported by the parser.
app/src/main/res/values/strings.xml Updates the user-facing “new in this update” text to reference the new mXparser version.
app/libs/mXparser-v.4.2.0-jdk.1.7.jar Legacy local JAR referenced by the PR’s migration context (binary change not shown in diff).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Comment thread app/build.gradle Outdated
androidTestImplementation 'androidx.test.ext:junit:1.1.5'
androidTestImplementation 'androidx.test.espresso:espresso-core:3.6.1'
androidTestImplementation 'androidx.test.espresso:espresso-intents:3.6.1'
implementation fileTree(dir: 'libs', include: ['*.aar', '*.jar'], exclude: [])

Copilot AI Mar 7, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The module still includes a local fileTree(dir: 'libs', include: ['*.aar', '*.jar']) dependency, but there is no app/libs directory in the repo. Since this PR migrates mXparser to Maven, consider removing this fileTree (or narrowing it to specific artifacts) to avoid confusion and accidental re-introduction of local JARs later.

Suggested change
implementation fileTree(dir: 'libs', include: ['*.aar', '*.jar'], exclude: [])

Copilot uses AI. Check for mistakes.
- Call License.iConfirmNonCommercialUse in SolvePuzzle, as required by
  mXparser 5+ for redistribution (this app is free, with no ads or IAP)
- Ship the mXparser dual license text in assets/, since the license
  requires it in binary distributions and AGP strips META-INF/LICENSE
- Update the mXparser version in the es, de and ar intro strings
- Remove the now-unused libs fileTree and kotlin-stdlib dependencies
- Replace a stray tab with spaces in AnswerCheckerTest

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HwXCdf3QVF4xVgmuSMH3oh
@atorch
atorch marked this pull request as ready for review October 31, 2026 03:43
Resolve conflict in values-ar/strings.xml by keeping the updated Arabic
translation from master with the mXparser version bumped to 6.1.0.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HwXCdf3QVF4xVgmuSMH3oh
The job relied on the runner image's default JDK. The ubuntu-26.04 image
defaults to a JDK that Gradle 8.11.1 can't run on ("Unsupported class
file major version 69"), so set up Java 17 as the build job already does.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HwXCdf3QVF4xVgmuSMH3oh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants