Skip to content

Update gems and rubocop - #65

Merged
brunto merged 3 commits into
mainfrom
update_gems
Sep 16, 2025
Merged

brunto merged 3 commits into
mainfrom
update_gems

Conversation

@brunto

@brunto brunto commented Sep 16, 2025

Copy link
Copy Markdown
Member

This pull request updates the Scripsit gem to version 0.4, modernizes its Ruby and Rails dependencies, and standardizes code style and configuration. The most significant changes include updating the gemspec for new dependencies and Ruby/Rails versions, switching to a standardized Rubocop configuration, and consistently using double quotes across the codebase.

Dependency and configuration updates:

  • Updated scripsit.gemspec to require Ruby 3.2.8 or newer and Rails 7.0+, added rubocop-rails-omakase as a dependency, and improved gem summary and description.
  • Updated the gem version to "0.4" in lib/scripsit/version.rb.
  • Replaced the custom .rubocop.yml with inheritance from rubocop-rails-omakase for standardized code style.

Code style consistency:

Metadata and documentation:

  • Updated gem author and contact information in scripsit.gemspec.
  • Improved gem summary and description to clarify features and capabilities.

Compatibility and maintenance:

  • Updated Rails and Ruby version requirements for improved compatibility and future maintenance.

Let me know if you have questions about any of these updates or want to discuss how they affect development or usage!

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request updates the Scripsit gem to version 0.4, modernizes dependencies for Ruby 3.2.8+ and Rails 7.0+, and standardizes code style using rubocop-rails-omakase. The changes focus on dependency updates, code style consistency, and improved gem metadata.

  • Updated gem dependencies and requirements for modern Ruby/Rails versions
  • Replaced custom Rubocop configuration with standardized rubocop-rails-omakase inheritance
  • Consistently changed all string literals from single quotes to double quotes throughout the codebase

Reviewed Changes

Copilot reviewed 26 out of 36 changed files in this pull request and generated no comments.

Show a summary per file
File Description
scripsit.gemspec Updated gem metadata, dependencies, and Ruby/Rails version requirements
lib/scripsit/version.rb Bumped version to 0.4 with double quote consistency
.rubocop.yml Replaced custom configuration with rubocop-rails-omakase inheritance
Multiple test files Updated require statements to use double quotes
Configuration files Changed string literals to double quotes for consistency
Application files Updated string literals in mailers and models to use double quotes

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

ciremoussadia
ciremoussadia previously approved these changes Sep 16, 2025
@brunto
brunto dismissed ciremoussadia’s stale review September 16, 2025 12:08

The merge-base changed after approval.

@brunto
brunto merged commit 80eb317 into main Sep 16, 2025
3 checks passed
@brunto
brunto deleted the update_gems branch September 16, 2025 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants