Repository navigation
Update gems and rubocop - #65
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request updates the Scripsit gem to version 0.4, modernizes dependencies for Ruby 3.2.8+ and Rails 7.0+, and standardizes code style using rubocop-rails-omakase. The changes focus on dependency updates, code style consistency, and improved gem metadata.
- Updated gem dependencies and requirements for modern Ruby/Rails versions
- Replaced custom Rubocop configuration with standardized
rubocop-rails-omakaseinheritance - Consistently changed all string literals from single quotes to double quotes throughout the codebase
Reviewed Changes
Copilot reviewed 26 out of 36 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| scripsit.gemspec | Updated gem metadata, dependencies, and Ruby/Rails version requirements |
| lib/scripsit/version.rb | Bumped version to 0.4 with double quote consistency |
| .rubocop.yml | Replaced custom configuration with rubocop-rails-omakase inheritance |
| Multiple test files | Updated require statements to use double quotes |
| Configuration files | Changed string literals to double quotes for consistency |
| Application files | Updated string literals in mailers and models to use double quotes |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
ciremoussadia
previously approved these changes
Sep 16, 2025
brunto
dismissed
ciremoussadia’s stale review
September 16, 2025 12:08
The merge-base changed after approval.
ciremoussadia
approved these changes
Sep 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the Scripsit gem to version 0.4, modernizes its Ruby and Rails dependencies, and standardizes code style and configuration. The most significant changes include updating the gemspec for new dependencies and Ruby/Rails versions, switching to a standardized Rubocop configuration, and consistently using double quotes across the codebase.
Dependency and configuration updates:
scripsit.gemspecto require Ruby 3.2.8 or newer and Rails 7.0+, addedrubocop-rails-omakaseas a dependency, and improved gem summary and description."0.4"inlib/scripsit/version.rb..rubocop.ymlwith inheritance fromrubocop-rails-omakasefor standardized code style.Code style consistency:
Gemfile, mailers, models, and configuration files. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14]Metadata and documentation:
scripsit.gemspec.Compatibility and maintenance:
Let me know if you have questions about any of these updates or want to discuss how they affect development or usage!