Repository navigation
Fix: reject invalid UTF-8 with 422 instead of 500 - #49
Merged
Merged
Conversation
DuckDB's Value(string) throws Invalid Input on invalid UTF-8. Three unprotected construction sites in HandleRequest's binding loop (BindParamValue, the number-like probe, the PARAM constraint check) let that throw escape as a 500 with a serialized-exception body -- and on POST /mcp it broke the JSON-RPC envelope with a raw HTTP 500. Probe once per parameter right after `raw` is assigned so malformed bytes become a 422 on the parameter that carried them, covering query/form/header/cookie/body locations.
asubbarao
marked this pull request as ready for review
October 17, 2026 04:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
quackapi bug-hunt 2026-10-15: param validation rejects invalid UTF-8 with 422 instead of 500. Draft PR to run CI.