Repository navigation
fix(cli): prevent special files from hanging workspace connections - #26
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A write to a named pipe currently blocks the native file connector indefinitely, leaving the browser waiting and preventing further file operations. Restrict connected-workspace I/O to regular files, omit special files from listings, and validate opened handles before truncation. Unix opens are nonblocking so a FIFO replacement during open cannot hang the process.
The regression uses the real CLI and a real named pipe. It failed by timing out before the fix and now verifies that reads/writes are rejected and the connector can still read a normal file afterward.
Validation passed locally:
cargo fmt --all --check,cargo clippy --all-targets -- -D warnings,cargo test(84 tests), native build, andpython3 scripts/test-setup-pty.py.No release or production deployment is included. Native Windows is not a published release target; the Unix-specific FIFO regression runs on macOS/Linux.