Repository navigation
fix(openai): preserve final arguments and suppress duplicate completions - #94
Merged
Merged
Conversation
This was referenced Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The OpenAI Responses adapter restarted completed IDs before checking duplicate suppression and ignored final
argumentswhen a call was already active. Replaying a completion emitted a second result; missing or incomplete deltas could fail even when the completion supplied valid JSON.Route completion events through the shared completion handler with the provider's final arguments. This preserves implicit starts, manual history, explicit ID reuse, and snapshot behavior while applying the existing byte/depth limits to final replacements.
Added regression coverage for manual and managed readers, both snapshot modes, duplicate events, matching/replaced final inputs, EOF finalization, and terminal failure cleanup. All four new tests fail against the previous implementation.
Validation:
pnpm check(201 JavaScript tests, 11 Rust tests, type/syntax checks, Rust formatting and clippy),pnpm pack:check, andpnpm test:browserusing the documented installed-Chrome override.