Repository navigation
feat(cohere): stream v2 tool arguments - #103
Merged
Merged
Conversation
Kinfe123
commented
Oct 30, 2026
Kinfe123
left a comment
Collaborator
Author
There was a problem hiding this comment.
lgtm, cohere sdk and wire events preserve streamed tool arguments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #102.
Problem
Cohere v2 streams tool calls as indexed start/delta/end events. Its TypeScript SDK also converts wire
tool_callsfields totoolCalls, so a consumer that only understands the wire shape silently misses SDK arguments.Change
Add
streamfold/cohere, using the existing integration and parser pool. Accept both the SDK and decoded wire envelopes, correlate indexes with tool IDs, and finalize at tool-call end or EOF. Ignore text and tool-plan events; reject malformed input and generation error messages while releasing active parsers. Cohere remains a development-only dependency.Verification
pnpm typecheckincludesCohereClientV2.chatStream()passed directly toreadStructuredand manual consumption.pnpm release:check: 201 JavaScript tests and 11 Rust tests pass, plus type/syntax, WASM, formatting, Clippy, and package checks.Public surface
Adds
streamfold/cohere,cohere,createStructuredStream, andCohereToolCallEvent. Updates README/API documentation and the unreleased changelog. No existing export or runtime dependency changes.