Repository navigation
Conversation
Remove the bootstrap step that configured NPM_TOKEN when the secret was set, guard against any npm token returning to the release workflow, and describe trusted publishing as the only publishing path in RELEASING.md.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Releases still publish to npm with the long-lived
NPM_TOKENsecret (set 2026-09-10). The publish job already hasid-token: write, and its bootstrap step falls back to trusted publishing only when the secret is unset.RELEASING.mdplanned to finish this migration after the first releases, but it never happened.Change
release.yml: remove the "Configure bootstrap npm token when present" step.npm publish(npm 11.20.0 with Node 26.13.0) then authenticates through the job's OIDC token.package/test/release-workflow.test.js: the publish job must keepid-token: write, and noNPM_TOKEN,NODE_AUTH_TOKENor_authTokenmay appear anywhere in the release workflow. Checked locally: it fails against current main and passes here.RELEASING.md: trusted publishing is described as the only path, plus how a brand-new platform package gets its first publish.Before merging (draft until done)
On npmjs.com, add a trusted publisher to each of the 9 packages (
riftriplus the 8riftri-<platform>packages): package Settings, Trusted Publisher, GitHub Actions, with organizationassistant-ui, repositoryriftri, workflowrelease.yml, and no environment.Merging before that would make the next release's publish step fail authentication. The publish script is restartable, so it would recover once the publishers are added, but it is better avoided.
After merging
NPM_TOKENrepository secret.