Skip to content

fleet-status: drop the retired Second Read lane - #214

Merged
askalf merged 1 commit into
masterfrom
chore/drop-second-read
Sep 25, 2026
Merged

askalf merged 1 commit into
masterfrom
chore/drop-second-read

Conversation

@askalf

@askalf askalf commented Sep 25, 2026

Copy link
Copy Markdown
Owner

The Second Read has been retired: operator decision, 2026-09-25. fleet/second-read is no longer a required check on any repo, and nothing posts a verdict for it anymore, so this lane would sit at pending forever.

  • scripts/fleet-status.mjs now posts only fleet/verify and fleet/review. SECOND_READ_LOGIN, secondReadAtHead and the fleet/second-read lane are gone.
  • The tests drop every Second Read case. The shared checks now expect two lanes where they expected three.

The remaining fleet-status tests all pass locally with no Second Read references left in the script or its test.

fleet/second-read is no longer required and nothing posts it; the script
posts fleet/verify and fleet/review only.
@github-actions github-actions Bot added tests Test suite and CI size/M 50-199 hand-written lines labels Sep 25, 2026

@sprayberry-redline sprayberry-redline left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review from the Sprayberry Labs fleet code reviewer.
Reviewed by the gating lane (gating review).

Verdict: approve. No blocking findings at head 635aa7b6a06d497ed2ae986b5fc05fb6a84b5058.

What I checked

  • Required CI at the live head: every test (…) matrix job and analyze (javascript-typescript) pass; fleet/verify is green ("Required CI passed at 635aa7b"). The non-required self-test job, which runs node scripts/fleet-status.test.mjs, also passes at this head, so the trimmed test file executed in CI.
  • The diff is a pure removal: SECOND_READ_LOGIN, secondReadAtHead, the secondRead context and the third out.push branch in laneStatuses are gone, and every test that touched them is dropped. OWN_CONTEXTS is derived from CONTEXTS, so the reconcile loop stops looking for fleet/second-read without a separate edit. No other call site existed: a recursive grep of the head checkout for second[ _-]?read / secondread returns nothing in scripts/, .github/, or docs.
  • laneStatuses still returns verify and review with the same states and descriptions as before; only the third element is gone. The remaining tests were updated from three-lane to two-lane expectations consistently (states.join() === 'success,success', 'CI passed: Redline is waited on…').
  • Tell pass over the title, body, commit message, and code comments: nothing that reads as generated; the commit message is in the repo's fleet-status: … style.

Non-blocking notes

  • scripts/fleet-status.mjs:174: removing the Second Read block left two consecutive blank lines before return out.map(...). Cosmetic.
  • scripts/fleet-status.test.mjs:123: the 140-character cap check now only asserts laneStatuses(base()).every((r) => r.description.length <= 140), and with the Second Read reason gone, no remaining description can approach 140 characters, so fit's truncation branch is no longer exercised by any test (the "140-character edge" block was deleted with it). Either a direct assertion on a long input, or dropping fit since nothing can exceed the cap anymore, would keep the test meaningful. Not required to merge.
  • The head commit still carries a stale fleet/second-read: pending status posted by the pre-change script. It is harmless once the context is no longer required on master (I could not read branch protection with this token, so I take the PR body's word for that).

Not checked

I did not run the test suite locally; CI is the test signal here.

@askalf
askalf merged commit 0e0b714 into master Sep 25, 2026
25 of 26 checks passed
@askalf
askalf deleted the chore/drop-second-read branch September 25, 2026 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/M 50-199 hand-written lines tests Test suite and CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants