Conversation
…erify publishes Review of every workflow here: all were green on their recent runs and pass actionlint + shellcheck; the gaps were in what CI never looked at. - ci: `package` job installs the `npm pack` tarball into an empty project (ubuntu + windows, node 20) and drives the installed CLI, truecopy-mcp and library. The suite imports ./src from the checkout, so a broken published package was invisible to it. - ci: Node 24 (active LTS, what publish.yml runs) joins the test matrix. - ci: actionlint job, binary pinned by version and sha256. - marketplace-watch: re-run on master pushes that change acceptances or detection, and serialize runs. #207 merged 40 minutes after the run that flagged its skill, so the badge stayed red until the next daily run. - publish: after `npm publish`, install that version back from the registry, check it runs and reports the right version, and `npm audit signatures`. - truecopy-gate: verify-attestation on the release tarball it installs. - codeql: add the `actions` language so workflows get scanned too. - docker: also run when truecopy.lock or demo/clean-mcp.json change; both are COPY'd into the image and verified by its smoke test. - test: release-hygiene checks the CHANGELOG section, lockfile and documented pins match package.json, so a bump can't strand them. Fixes `truecopy --version`, which printed usage and exited 2 (0.10.4 still does); regression test added, CHANGELOG entry under Unreleased. Claude-Session: https://claude.ai/code/session_01XZEotnWUeFC5V4AHMKBM9W
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
GNU tar reads `D:\a\_temp\…\x.tgz` as host `D` plus a remote path, so the
windows-latest leg died at the listing ("Cannot connect to D: resolve
failed"). List the tarball by its bare name after cd'ing into it, and work
from a POSIX RUNNER_TEMP (cygpath -u) under Git Bash so no later step
depends on bash resolving a drive-letter path.
Claude-Session: https://claude.ai/code/session_01XZEotnWUeFC5V4AHMKBM9W
CodeQL (js/incomplete-sanitization) flagged escaping only the dots of the version before interpolating it into a RegExp. Parse the `## [x] - date` headings and compare x to package.json's version directly: nothing left to escape, and a bump without its section still fails. Claude-Session: https://claude.ai/code/session_01XZEotnWUeFC5V4AHMKBM9W
Owner
Author
|
Replaced by #211: the same change as one commit, without the model attribution in the commit trailers and body, and with the em dashes in the added text rewritten. |
7 tasks
askalf
added a commit
that referenced
this pull request
Sep 25, 2026
…erify publishes (#211) * ci: test the shipped package, lint workflows, rescan on acceptance, verify publishes Same change as #210, as one commit. * ci, cli: drop two comments that narrate the change instead of the code * test: drop the release-hygiene header comment * ci: comments state what the workflows do, not why they changed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
This is the CI half of #208, which was closed before it landed. It's rebased onto master after the 0.10.4 release (#209) and has no release bump of its own.
I reviewed every workflow. All recent runs were green, and everything passes actionlint and shellcheck, so the gaps were in what CI never checked:
ci.ymlpackagejob: installs thenpm packtarball into an empty project (ubuntu + windows, node 20), then runs the installed CLI,truecopy-mcpand the library./srcstraight from the checkout, so a broken published package was invisibleci.ymlpublish.ymlalready usesci.ymlrun:script through shellcheckmarketplace-watch.ymlwatch, so two runs must never overlap.publish.ymlnpm publish: install that version back from the registry, check--version, check it flags the poisoned demo, runnpm audit signaturestruecopy-gate.ymlverify-attestation: 'true'codeql.ymlactionslanguagedocker.ymltruecopy.lockordemo/clean-mcp.jsonchangetest/release-hygiene.test.mjspackage.jsonBug fix:
truecopy --versionprinted the usage text and exited 2, even though both issue templates ask reporters for its output. The just-published 0.10.4 still does this.--version,-vandversionnow print the version. Regression test added, and the CHANGELOG entry is under[Unreleased].Why
CI tested the source tree but not the package users install. It also didn't confirm a publish was actually usable, and it left the watch badge red after a triage PR merged.
How it was verified
npm test: 274 tests, 273 pass, 0 fail, 1 skipped (Node 22). Before the new tests, the suite also passed on Node 24.21.0 locally.actionlint1.7.12 with shellcheck 0.11.0: clean on all workflowspackagejob's two scripts locally, taken straight fromci.yml. The installed CLI reports its version, the clean demo passes, the poisoned demo exits 1,verifypasses,truecopy-mcpliststruecopy-verify, truecopy-status, and the library has 33 exports.npm audit signaturesagainst the published@askalf/truecopy@0.10.3: 1 verified registry signature, 1 verified attestationverify-attestationhas something to verify🤖 Generated with Claude Code
https://claude.ai/code/session_01XZEotnWUeFC5V4AHMKBM9W
Generated by Claude Code