Skip to content

ci: remove unstick-prs.yml; armed BEHIND PRs are already advanced by the maintainer's sweep - #203

Merged
askalf merged 2 commits into
masterfrom
ci/remove-unstick-prs
Sep 23, 2026
Merged

askalf merged 2 commits into
masterfrom
ci/remove-unstick-prs

Conversation

@askalf

@askalf askalf commented Sep 23, 2026

Copy link
Copy Markdown
Owner

Removes .github/workflows/unstick-prs.yml.

Nothing else in the repo references the workflow or the secret.

…ces armed BEHIND PRs here

unstick-prs needed a PR_SWEEP_TOKEN secret that was never set, so every one of its 94 runs in the last 14 days exited at its guard as a green no-op. The same job (update-branch on PRs that are armed for auto-merge and BEHIND) runs from the fleet's pr-behind-sweep across every public askalf repo, truecopy included.
@github-actions github-actions Bot added github_actions Pull requests that update GitHub Actions code size/M 50-199 hand-written lines labels Sep 23, 2026
@askalf
askalf enabled auto-merge (squash) September 23, 2026 15:53

@sprayberry-secondread sprayberry-secondread left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review from the Sprayberry Labs fleet code reviewer.

Reviewed by the Claude second-opinion lane (second opinion, non-gating; the gating review is posted separately).

No blocking issues found in this workflow-only deletion.

Read the full 149-line deletion of .github/workflows/unstick-prs.yml. The removed workflow has schedule and manual-dispatch entry points, not a pull-request check, and its missing-token guard exits before listing or updating any PR. The latest run I inspected (35891960798) actually emitted PR_SWEEP_TOKEN is not set — nothing to do, supporting the claim that this currently does no branch-update work.

What's good: the change is narrowly scoped, removes an idle scheduled job without changing application code or CI test definitions, and explains where branch-update responsibility now lives. All reported PR checks pass, including Node 20/22 across Linux, macOS, and Windows. No local test suite was run.

Scope limit: I did not independently verify the external maintainer sweep, the complete 94-run history, or a repository-wide reference search. Removing this file also removes its manual-dispatch fallback; continued automatic branch advancement depends on the external sweep described in the PR.

@sprayberry-redline sprayberry-redline left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review from the Sprayberry Labs fleet code reviewer.

Reviewed by the GPT gating lane (gating review).

APPROVE: no blocking findings in the workflow removal.

Reviewed the complete 149-line deletion, PR description, and commit messages at 45182cd4985c5d5f487f902a3ed2e0f5d6478884. The deleted workflow has only scheduled and manual triggers; it is not a reusable workflow or a pull-request test job. Removing it does not modify application code or the remaining test workflows. Its missing-token guard confirms the described successful no-op behavior when the secret is absent.

All reported CI checks pass, including the Node 20/22 test matrix on Linux, macOS, and Windows, CodeQL, triage, and pinned-skills verification. This CI-only change is exempt from the separate verification requirement; no local suite was run. I did not independently audit the external maintainer sweep or the historical secret configuration.

What's good: the change is limited to removing one redundant automation entry point, without unrelated edits.

@askalf
askalf merged commit 5840b32 into master Sep 23, 2026
10 checks passed
@askalf
askalf deleted the ci/remove-unstick-prs branch September 23, 2026 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code size/M 50-199 hand-written lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants