ci: scorecard comment says what the job token reads - #123
Merged
Merged
Conversation
askalf
enabled auto-merge (squash)
September 26, 2026 01:59
sprayberry-redline
approved these changes
Sep 26, 2026
sprayberry-redline
left a comment
Collaborator
There was a problem hiding this comment.
Automated review from the Sprayberry Labs fleet code reviewer.
Reviewed by the gating lane (gating review).
Verdict: approve. Approving. The diff only rewrites the comment above repo_token in .github/workflows/scorecard.yml; the ${{ secrets.SCORECARD_TOKEN || github.token }} expression, job permissions, triggers, and SHA-pinned actions are untouched. I checked the workflow for security risks (permissions, third-party action pinning, secret handling, untrusted input) and the new comment text for generated-sounding prose, AI attribution, and secret or internal-path exposure; none found. One non-blocking note on the comment wording.
Minor:
.github/workflows/scorecard.yml:37: The parenthetical refers to "an earlier comment" that no longer exists once this merges, so future readers have no way to know what it means, and the "5-8 of 10 here" score will silently go stale as branch rules change. Both are narration about the change rather than a constraint the code cannot show.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From the 2026-09-25 audit of every action, item 24: the comment above
repo_tokensays the Branch-Protection check "errors out (-1)" without aSCORECARD_TOKENsecret. It does not: no repo in the estate sets the secret, every run takes thegithub.tokenfallback, and Branch-Protection scores 5-8 from the public rules. The comment now says what the token can and cannot read. The expression is unchanged, so a PAT set later still takes precedence.