Skip to content

ci: scorecard comment says what the job token reads - #123

Merged
askalf merged 1 commit into
masterfrom
ci/scorecard-comment
Sep 26, 2026
Merged

askalf merged 1 commit into
masterfrom
ci/scorecard-comment

Conversation

@askalf

@askalf askalf commented Sep 26, 2026

Copy link
Copy Markdown
Owner

From the 2026-09-25 audit of every action, item 24: the comment above repo_token says the Branch-Protection check "errors out (-1)" without a SCORECARD_TOKEN secret. It does not: no repo in the estate sets the secret, every run takes the github.token fallback, and Branch-Protection scores 5-8 from the public rules. The comment now says what the token can and cannot read. The expression is unchanged, so a PAT set later still takes precedence.

@askalf
askalf enabled auto-merge (squash) September 26, 2026 01:59

@sprayberry-redline sprayberry-redline left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review from the Sprayberry Labs fleet code reviewer.

Reviewed by the gating lane (gating review).

Verdict: approve. Approving. The diff only rewrites the comment above repo_token in .github/workflows/scorecard.yml; the ${{ secrets.SCORECARD_TOKEN || github.token }} expression, job permissions, triggers, and SHA-pinned actions are untouched. I checked the workflow for security risks (permissions, third-party action pinning, secret handling, untrusted input) and the new comment text for generated-sounding prose, AI attribution, and secret or internal-path exposure; none found. One non-blocking note on the comment wording.

Minor:

  • .github/workflows/scorecard.yml:37: The parenthetical refers to "an earlier comment" that no longer exists once this merges, so future readers have no way to know what it means, and the "5-8 of 10 here" score will silently go stale as branch rules change. Both are narration about the change rather than a constraint the code cannot show.

@github-actions github-actions Bot added github_actions Pull requests that update GitHub Actions code size/S 10-49 hand-written lines labels Sep 26, 2026
@askalf
askalf merged commit 1b79629 into master Sep 26, 2026
16 checks passed
@askalf
askalf deleted the ci/scorecard-comment branch September 26, 2026 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code size/S 10-49 hand-written lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants