Skip to content

ci: drop the review kick; forge dispatches reviews from webhooks - #84

Merged
askalf merged 1 commit into
mainfrom
ci/drop-review-kick
Sep 25, 2026
Merged

askalf merged 1 commit into
mainfrom
ci/drop-review-kick

Conversation

@askalf

@askalf askalf commented Sep 25, 2026

Copy link
Copy Markdown
Owner

What does this PR do?

Removes .github/workflows/review-kick.yml. It fails on every amnesia PR and no longer does anything useful.

  • It can't work here. It runs on [self-hosted, amnesia], whose runner is the non-root gha-runner, and it tries to start review-dispatch.service on the host. systemd refuses: Failed to start review-dispatch.service: Interactive authentication required (run 36086985110, on ci: fleet review lanes show up as commit statuses on the PR head #83). Every amnesia PR has carried that red kick check.
  • Nothing needs it. The fleet's reviews are dispatched by forge from repository webhooks (pull_request, pull_request_review, issue_comment, check_suite) plus its 15-minute review sweep. The shell dispatcher's minute-by-minute kick watcher is off on the box, and its 30-minute timer remains as a backstop.

No other file references it. .github-only change.

How to test

  • The next amnesia PR has no kick check, and its fleet reviews still arrive (webhook dispatch).

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Deploying amnesia-site with  Cloudflare Pages  Cloudflare Pages

Latest commit: 025261e
Status: ✅  Deploy successful!
Preview URL: https://7da6c7ef.amnesia-site.pages.dev
Branch Preview URL: https://ci-drop-review-kick.amnesia-site.pages.dev

View logs

@github-actions github-actions Bot added github_actions Pull requests that update GitHub Actions code size/M 50-199 hand-written lines labels Sep 25, 2026
@askalf
askalf enabled auto-merge (squash) September 25, 2026 02:53

@sprayberry-redline sprayberry-redline left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review from the Sprayberry Labs fleet code reviewer.
Reviewed by the GPT gating lane (gating review).

Verdict: APPROVE — no blocking issues found.

The deleted .github/workflows/review-kick.yml only attempted privileged systemctl operations from the self-hosted runner. Removing it eliminates the consistently failing check without changing application code. I also checked the full deleted workflow, the PR rationale, and the required CI checks at live head 025261e03e7ac3e9c58ed18ba9180051361debfe; all required checks pass.

What's good: this is a focused CI-only deletion with no unrelated changes.

@askalf
askalf merged commit 35f7be1 into main Sep 25, 2026
7 of 8 checks passed
@askalf
askalf deleted the ci/drop-review-kick branch September 25, 2026 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code size/M 50-199 hand-written lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants