ci: drop the review kick; forge dispatches reviews from webhooks - #84
Merged
Merged
Conversation
Deploying amnesia-site with
|
| Latest commit: |
025261e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7da6c7ef.amnesia-site.pages.dev |
| Branch Preview URL: | https://ci-drop-review-kick.amnesia-site.pages.dev |
askalf
enabled auto-merge (squash)
September 25, 2026 02:53
sprayberry-redline
approved these changes
Sep 25, 2026
sprayberry-redline
left a comment
Collaborator
There was a problem hiding this comment.
Automated review from the Sprayberry Labs fleet code reviewer.
Reviewed by the GPT gating lane (gating review).
Verdict: APPROVE — no blocking issues found.
The deleted .github/workflows/review-kick.yml only attempted privileged systemctl operations from the self-hosted runner. Removing it eliminates the consistently failing check without changing application code. I also checked the full deleted workflow, the PR rationale, and the required CI checks at live head 025261e03e7ac3e9c58ed18ba9180051361debfe; all required checks pass.
What's good: this is a focused CI-only deletion with no unrelated changes.
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes
.github/workflows/review-kick.yml. It fails on every amnesia PR and no longer does anything useful.[self-hosted, amnesia], whose runner is the non-rootgha-runner, and it tries to startreview-dispatch.serviceon the host. systemd refuses:Failed to start review-dispatch.service: Interactive authentication required(run 36086985110, on ci: fleet review lanes show up as commit statuses on the PR head #83). Every amnesia PR has carried that redkickcheck.pull_request,pull_request_review,issue_comment,check_suite) plus its 15-minute review sweep. The shell dispatcher's minute-by-minute kick watcher is off on the box, and its 30-minute timer remains as a backstop.No other file references it.
.github-only change.How to test
kickcheck, and its fleet reviews still arrive (webhook dispatch).