Repository navigation
fix(p2): update markers for extreme observations - #42
Merged
asiffer merged 3 commits intoSep 6, 2026
Merged
Conversation
shenxiangzhuang
had a problem deploying
to
npmjs
September 1, 2026 01:25 — with
GitHub Actions
Failure
shenxiangzhuang
had a problem deploying
to
npmjs
September 1, 2026 01:30 — with
GitHub Actions
Failure
Owner
|
I think you need to bump the version to pass the test ( |
Contributor
Author
|
OK, that makes sense. I suggested changing the CI because the dry run depends on the package version being unpublished, which could affect later PRs. However, since the actual staging step is already restricted to tags, I’m happy to follow your release workflow. I’ll bump the version to 3.1.0, close #43, and update the current PR accordingly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
3.1.0Fixes #41.
Tests
src/p2.cwith-Wall -Wextra -Werror -pedanticmake teston Ubuntutest/bin/p2_testexecution on Ubuntu: 4 tests, 0 failuresFor the 100 seeds and 20 probabilities covered by
p2_test, the mean uniform error changes from0.001191to0.000657, and the mean Gaussian relative error changes from0.006559to0.007278. Both remain within the existing0.01aggregate bound. Individual errors above the diagnostic thresholds continue to be reported by the test.